[PATCH v3] validation: pool: fix uarea init test for external pools #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Sep 7, 2023
test/validation/api/pool/pool.c
Outdated
Comment on lines
2053
to
2060
| uint32_t max_payload; | ||
|
|
||
| CU_ASSERT(data.mark[i] == 1); | ||
|
|
||
| pkts[i] = odp_packet_alloc(pool, (param.pkt.buf_size - param.pkt.headroom) / 2); | ||
| max_payload = param.pkt.buf_size; | ||
| max_payload -= capa.pkt.odp_header_size + param.pkt.app_header_size; | ||
| max_payload -= capa.pkt.odp_trailer_size; | ||
| max_payload -= capa.pkt.max_headroom_size; | ||
| pkts[i] = odp_packet_alloc(pool, max_payload); |
There was a problem hiding this comment.
I'd move calculating max_payload outside the for loop and perhaps deducting max_headroom_size after header sizes would be more logical, but otherwise looking good.
ashwinyes
force-pushed
the
fix_uarea_init_test
branch
from
47c7764
to
5776d18
Compare
odpbuild
changed the title
MatiasElo
approved these changes
Sep 7, 2023
|
Hi @ashwinyes, please add tags so this PR can be merged. |
|
Ping @ashwinyes |
The max payload of single segmented packets in external pools depends on the odp_header_size, app_header_size, max_headroom_size and odp_trailer_size. Take all these into consideration when doing packet alloc from external pools so that allocations don't fail. Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com> Reviewed-by: Matias Elo <matias.elo@nokia.com>
ashwinyes
force-pushed
the
fix_uarea_init_test
branch
from
5776d18
to
88e2baf
Compare
odpbuild
changed the title
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max payload of single segmented packets in external pools depends on the odp_header_size, app_header_size, max_headroom_size and odp_trailer_size.
Take all these into consideration when doing packet alloc from external pools so that allocations don't fail.