[PATCH v5] quell GCC 13.1 bound check warnings #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
odpbuild
changed the title
|
v2:
|
JereLeppanen
changed the title
JereLeppanen
changed the title
JereLeppanen
force-pushed
the
dev/gcc-13
branch
from
2f7c6ca
to
81e7bc1
Compare
odpbuild
changed the title
|
v3:
|
JereLeppanen
force-pushed
the
dev/gcc-13
branch
from
81e7bc1
to
f3847e3
Compare
odpbuild
changed the title
|
v4:
|
JannePeltonen
approved these changes
Nov 23, 2023
Quell false positive GCC 13.1 -Warray-bounds and -Wstringop-overflow warnings. The warnings still appear during LTO linking, because GCC does not carry diagnostic pragmas to the linking stage. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
…tion When compiling with GCC 13.1 and -Wpedantic, struct sset_info causes the error "invalid use of structure with flexible array member [-Werror=pedantic]". The flexible array member in this case is the data member of struct ethtool_sset_info. In order to reserve space for it, turn sset_info into a union, and make the next member in the union the size of struct ethtool_sset_info and the data. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
Also c++ programs need -Wno-error=stringop-overflow flag, in order to avoid errors during linking, when using LTO. Signed-off-by: Jere Leppänen <jere.leppanen@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
JereLeppanen
force-pushed
the
dev/gcc-13
branch
from
f3847e3
to
f669ef5
Compare
odpbuild
changed the title
|
v5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quell a few -Warray-bounds and -Wstringop-overflow warnings with GCC 13.1, with and without -Wpedantic.
The question here is do we keep adding these pragmas to the code or do we just disable -Warray-bounds and -Wstringop-overflow?