Skip to content

Commit

Permalink
Merge pull request #1340 from ghutchis/update-mac-notarize
Browse files Browse the repository at this point in the history
Update Mac notarization procedure to skip npm package
  • Loading branch information
ghutchis authored Sep 13, 2023
2 parents ef48ab8 + a819220 commit 7964d25
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build_cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ jobs:
# check if we have the password and the username
if [ -n "${NOTARIZE_PASSWORD}" ] && [ -n "${NOTARIZE_USERNAME}" ]; then
codesign -s "$CODESIGN_IDENTITY" --timestamp Avogadro2*.dmg
npx notarize-cli --file Avogadro2*.dmg
xcrun notarytool submit Avogadro2*.dmg --apple-id "$NOTARIZE_USERNAME" --password "NOTARIZE_PASSWORD" --verbose --wait
xcrun stapler staple -v Avogadro2*.dmg
fi
working-directory: ${{ runner.workspace }}/build/avogadroapp
env:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build_m1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ jobs:
echo "codesign DMG"
codesign -s "$CODESIGN_IDENTITY" --timestamp Avogadro2*.dmg
echo "notarizing"
npx notarize-cli --file Avogadro2*.dmg
xcrun notarytool submit Avogadro2*.dmg --apple-id "$NOTARIZE_USERNAME" --password "NOTARIZE_PASSWORD" --verbose --wait
xcrun stapler staple -v Avogadro2*.dmg
fi
env:
NOTARIZE_USERNAME: ${{ secrets.AC_USERNAME }}
Expand Down

0 comments on commit 7964d25

Please sign in to comment.