-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/window event race condition #842
base: main
Are you sure you want to change the base?
Fix/window event race condition #842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Animesh404 ! I left a few comments.
Can you please also test out https://github.com/Kalmat/PyWinCtl ? I believe it should also support MacOS.
…nimesh404/OpenAdapt into fix/WindowEvent-race-condition
@Animesh404 please consolidate the alembic scripts into a single migration. You can do this by downgrading the two that you have currently applied:
Then generate a new revision, add it, and remove the existing ones. |
…nimesh404/OpenAdapt into fix/WindowEvent-race-condition
Thanks @Animesh404 ! Can you please show screenshots of a11y events in visualize.py and the dashboard? |
Sure @abrichr |
@Animesh404 please correct me if I'm wrong but I don't see any accessibility data in the dashboard screenshot |
|
What kind of change does this PR introduce?
a bugfix for #816
Summary
WindowEvent
model and created a new modelA11yEvent
which points to the relevantWindowEvent
crud.py
by adding insert_a11y_eventrecord.py
where we usequeue
to map whichWindowEvent
is waiting for its correspondingA11yEvent
Checklist