Implemented model cursor for visual feedback #760

[Subh231004]

Implemented model cursor for visual feedback
/claim #760

What kind of change does this PR introduce?

Summary

Checklist

• My code follows the style guidelines of OpenAdapt
• I have performed a self-review of my code
• If applicable, I have added tests to prove my fix is functional/effective
• I have linted my code locally prior to submission
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
• New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

[abrichr]

Good start! It might be easier to copy and paste the contents of vanilla.py and start from there. It's not clear to me what is the right abstraction for strategies that build on it.

[abrichr]

I think probably we want to use a methodology similar to VisualReplayStrategy (i.e. segmentation + description) to generate initial cursor target candidates, then use the model cursor feedback to let it self-correct.

[Subh231004]

@abrichr I've made some changes in the files please review them and let me know if something more needs to be done

[abrichr]

@Subh231004 your code is unfortunately quite disorganized and difficult to read. I have enabled a build so that you can see the errors that will be reported by our style checkers. Please address those and I will be happy to take a closer look.

[Subh231004]

@abrichr can u please review the code I've tried to make it readable

[ayewo]

@abrichr

Just a quick FYI that similar low-effort PRs have been opened in other projects¹² that end up getting closed.

I only noticed because I got quite a few nonsensical GitHub notifications from Subh231004 here³ that have since been deleted by the maintainers.

Footnotes

1. https://github.com/langchain4j/langchain4j/pull/1316 ↩

2. https://github.com/gyroflow/gyroflow/pull/847 ↩

3. https://github.com/langchain4j/langchain4j/issues/1132 ↩

[Subh231004]

I'm a beginner to the open source world and I'm trying hard to get to the problem statements I've had a short conversation with the maintainer of OpenAdapt and I have his permission to work on it I am just following whatever he is suggesting me

…

On Sat, 22 Jun 2024, 3:07 pm Saïd, ***@***.***> wrote: @abrichr <https://github.com/abrichr> Just a quick FYI that similar low-effort PRs have been opened in other projects1 <#m_5310800255775685780_user-content-fn-1-d3fabde2417a5c3626868e381f6a1cdb> 2 <#m_5310800255775685780_user-content-fn-2-d3fabde2417a5c3626868e381f6a1cdb> that end up getting closed. I only noticed because I got quite a few nonsensical GitHub notifications from Subh231004 here3 <#m_5310800255775685780_user-content-fn-3-d3fabde2417a5c3626868e381f6a1cdb> that have since been deleted by the maintainers. Footnotes 1. langchain4j/langchain4j#1316 ↩ <#m_5310800255775685780_user-content-fnref-1-d3fabde2417a5c3626868e381f6a1cdb> 2. gyroflow/gyroflow#847 ↩ <#m_5310800255775685780_user-content-fnref-2-d3fabde2417a5c3626868e381f6a1cdb> 3. langchain4j/langchain4j#1132 ↩ <#m_5310800255775685780_user-content-fnref-3-d3fabde2417a5c3626868e381f6a1cdb> — Reply to this email directly, view it on GitHub <#781 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BESS73R4UGI6JPAFPOYJ5L3ZIVAXLAVCNFSM6AAAAABJR2DPHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBTHE3DCMBSHA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[ayewo]

I'm a beginner to the open source world and I'm trying hard to get to the problem statements I've had a short conversation with the maintainer of OpenAdapt and I have his permission to work on it I am just following whatever he is suggesting me

@Subh231004 I totally get that. I was merely commenting so Richard could calibrate his expectations accordingly.

[abrichr]

Thank you @ayewo .

@Subh231004 thank you for your efforts. I appreciate your desire to contribute and I encourage you to continue. However this code is unfortunately not reviewable in its current state.

I suggest you try a simpler problem before attempting this one.