-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the StartMenuDLL for classic theme support on the taskbar #1642
base: master
Are you sure you want to change the base?
Conversation
Fixed DLL code for classic theme support.
Yes, I understand that in this state, it is not mergeable. On the other hand, I imagine that it is possible if it becomes configurable (a possible option which will leave the choice to activate it). However, it seems to me that it didn't break the installations in the original version, but maybe that's because it was a previous version. I will try to compare the current version to previous versions. When modifying the DLL, I noticed a change in line 2957 (among the lines modified by valinet). For the other lines, it was identical. |
I'll look at the display issues in more detail (that said, I understood most of what the changes seem to do, as valinet explained the changes pretty well), and come back here if I know more. |
It would be also great to describe what exactly is the issue and steps to replicate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot be merged in current state. See discussion above.
Please, don't add binary installer to PR changes. It won't get merged that way. |
It wasn't on purpose, I wanted to add it to my fork, I didn't think it would add the file here. I'm deleting it right now. |
Since you have opened this PR, then all changes in the source branch of your fork are synced here. I'd probably suggest to just close this PR and probably submit new one once you finish it? |
Fixed DLL code for classic theme support.
These changes add classic theme support to the taskbar, as discussed here and here. The original author of these modifications is valinet