Vector to raster conversion #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The json should be valid but the automatic linter gives an error: |
|
You have to remove the spaces at the end of the return description. |
m-mohr
reviewed
Sep 30, 2023
m-mohr
reviewed
Sep 30, 2023
m-mohr
reviewed
Sep 30, 2023
m-mohr
reviewed
Sep 30, 2023
m-mohr
reviewed
Sep 30, 2023
| @@ -0,0 +1,60 @@ | |||
| { | |||
| "id": "vector_to_raster", | |||
| "description": "Creates a raster cube as output based on a vector cube. The values in the output raster cube are based on the numeric properties in the input vector cube.", | |||
There was a problem hiding this comment.
The values in the output raster cube are based on the numeric properties in the input vector cube.
What does this mean? Can this be explained a bit better/more precisely?
Generally, I think this needs more specific information about how the conversion is done to be testable in the future.
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #442