-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dateline #310
base: develop
Are you sure you want to change the base?
Dateline #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a test where the feature extent is outside of the valid bounds of target CRS? For instance, a feature with global extent, and target extent being some utm zone.
I think this is the reason for going via EPSG:4326 to compute the intersection safely.
Added a test for feature in LatLng and target extent in UTM.
|
There where already many cases where 2 different UTM extentds where used. Confirmed by logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it now assumes that utm is the only projection that has this issue.
EPSG:3035 is another example that we work with a lot.
It could be that the valid area of a crs is in fact available, maybe we can check on that.
The issue was an intersection calculation losing a lot of precision due to reprojecting and back.
Now the intersection between the feature and the requested extent is calculated in the target extent crs.
This made that some tests now load a smaller piece of the feature, on some places
{FloatConstantNoDataArrayTile@16026} ArrayTile(256,256,float32)
became{PaddedTile@15829} PaddedTile(ArrayTile(140,122,float32),17,134,256,256)