[Minor] Add Source and Image Component + other small performance improvements. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make code more efficent set blurryPlaceholder to false
|
Someone is attempting to deploy a commit to a Personal Account owned by @ObieMunoz on Vercel. @ObieMunoz first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @bertybot2, These changes look good overall. Please update the associated unit tests that are failing. |
CC: @bertybot |
|
@bertybot The automated vercel deployment is approved, you should be able to see the demo now. I can get you the api key if you'd like it locally. |
Whoops forgot to update the call when I re-added blur. |
|
released in #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added
Sourcecomponent and exposedImagecomponent so different images can be displayed at different viewports. Exposing the Image component also allows more fine-grained control.Other changes
Set
blurryPlaceholderdefault to off. Since theblurryPlaceholderadds an extra network request, and therefore degrades performance. It should only be added when the use case demands it. I think in most cases people will not need theblurryPlaceholdersince images load rather quickly when there is a small handful and therefore it should default to off.small code improvements
Notes
Really couldn't test the demo because I do not have a Hygraph token if I could get that Ill make sure it works.