Custom jar arguments & 1.2.1 #5
Conversation
There was a problem hiding this comment.
Glad you took the initiative. The feature implementation looks good thanks.
I have a couple of changes before I merge this request.
-
I think customServerArgs is more descriptive than customJarArgs in all variables and printouts.
-
I'd rather I compile and add the binary myself for security purposes. so commit "Built 1.2.1 jar" will be left out from the merge.
-
Most importantly, we need to consider users who are already using the plugin when we add something to the JSON storage. Right now they will get an error because the "customJarArgs" key wouldn't be present. So a simple if statement check in JSONStorage.java before trying to get that value would solve this. If the key is not present put the null default value.
|
That should work. I tested on an existing config without customServerArgs and it seemed to be fine now. |
Implemented a feature suggested in issue #3. Changed the version to 1.2.1 and built a new jar.