Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ’„ Style: λ³€κ²½ - footer μ•„μ΄μ½˜ μ™Έ 1 #48

Merged
merged 2 commits into from
Aug 21, 2024
Merged

πŸ’„ Style: λ³€κ²½ - footer μ•„μ΄μ½˜ μ™Έ 1 #48

merged 2 commits into from
Aug 21, 2024

Conversation

sobinibani
Copy link
Collaborator

@sobinibani sobinibani commented Aug 21, 2024 •
edited
Loading

κ°œμš”

  • footer μ•„μ΄μ½˜ μˆ˜μ •
  • main의 rounded 적용 μ•ˆλ˜λŠ” 문제 μˆ˜μ •

Issue μœ ν˜•

fixes: #2, #32

PR μœ ν˜•

μ–΄λ–€ λ³€κ²½ 사항이 μžˆλ‚˜μš”?

  • μƒˆλ‘œμš΄ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • CSS λ“± μ‚¬μš©μž UI λ””μžμΈ λ³€κ²½
  • μ½”λ“œ ν¬λ§·νŒ…, μ½”λ“œ μˆ˜μ •μ΄ μ—†μŒ
  • μ½”λ“œ λ¦¬νŒ©ν† λ§
  • ν•„μš”ν•œ 주석 μΆ”κ°€ 및 λ³€κ²½
  • λ¬Έμ„œ 파일 μΆ”κ°€ 및 μˆ˜μ •
  • ν…ŒμŠ€νŠΈ μ½”λ“œ, λ¦¬νŒ©ν† λ§ ν…ŒμŠ€νŠΈ μ½”λ“œ μΆ”κ°€
  • λΉŒλ“œ 업무 μˆ˜μ •, νŒ¨ν‚€μ§€ λ§€λ‹ˆμ € μˆ˜μ •
  • 파일 ν˜Ήμ€ 폴더λͺ… μˆ˜μ • λ˜λŠ” 이동
  • 파일 λ˜λŠ” μ½”λ“œ μ‚­μ œ

PR Checklist

PR이 λ‹€μŒ μš”κ΅¬ 사항을 μΆ©μ‘±ν•˜λŠ”μ§€ ν™•μΈν•˜μ„Έμš”.

  • 컀밋 λ©”μ‹œμ§€ μ»¨λ²€μ…˜μ— 맞게 μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό ν–ˆμŠ΅λ‹ˆλ‹€.(버그 μˆ˜μ •/κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈ).

@sobinibani sobinibani merged commit 261e0b2 into dev Aug 21, 2024
@sobinibani sobinibani deleted the home branch August 21, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yi-HyeonJu Yi-HyeonJu Yi-HyeonJu approved these changes

@Supernova-428 Supernova-428 Supernova-428 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λ ˆμ΄μ•„μ›ƒ
3 participants
@sobinibani @Supernova-428 @Yi-HyeonJu