enable static linking

[ghost]

pkg-config can't statically link libraries inside /usr/lib which usually where libraries are installed as stated here rust-lang/pkg-config-rs#102

This PR enable static linking via feature flags. To test extra dependencies is needed

Linux

sudo apt install libarchive-dev \
    libicu-dev \
    nettle-dev \
    libacl1-dev \
    liblzma-dev \
    libzstd-dev \
    liblz4-dev \
    libbz2-dev \
    zlib1g-dev \
    libxml2-dev

macOS

brew install icu4c libarchive bzip2 lz4 zlib expat
EXPORT PKG_CONFIG_PATH="/usr/local/opt/icu4c/lib/pkgconfig:/usr/local/opt/libarchive/lib/pkgconfig:/usr/local/opt/zlib/lib/pkgconfig:/usr/local/opt/expat/lib/pkgconfig"

[otavio]

@faldez awesome. Could you also add a CI job to validate this?

[ghost]

Should I add separate job for static and dynamic? Or I just install necessary packages to existing jobs?

[otavio]

I'd add it to the matrix so we ensure it works for all platforms.

[otavio]

@faldez could you take a look at this? it'd be awesome to have it being tested on CI.

[ghost]

I've added the deps for linux and macos, but I think I need to update rust cross image for aarch64 and armv7 tests

[otavio]

I'm trying to get #81 fixed before we extend the CI; it is currently failing on Windows.

[otavio]

Please rebase the PR.

[otavio]

I have committed the unrelated workflow changes and merged the Docker images. Thanks for all that.

I was reviewing the new code, and it is relatively complicated. So did you try the workaround in rust-lang/pkg-config-rs#102 (comment)? It'd be easier to understand if a good comment is added explaining the issue.

[ghost]

actually I haven't tried that, I think I did this before noticing that workaround. All I did is linking every library necessary manually instead of relying on pkg-config crates. I'll add comment to explains the steps.

though, it still failing on CI for nightly, because RUSTFLAGS override all flags setup in build.rs

is the workaround includes moving/symlink necessary paths to another directory and declare them as SYSROOT ?

[otavio]

Maybe, it's worth asking in the original issue about the workaround so we could use it here instead of adding all the linking of libraries manually?

[ghost]

I tried to get back to this, but someone state that workaround in rust-lang/pkg-config-rs#102 (comment) cannot be used when cross compiling rust-lang/pkg-config-rs#102 (comment). I think manually link all the necessary libraries is the only option for now.

[otavio]

@faldez please fix clippy issues, so we can try to get this merged.