Refactor and simplify verification process #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify the verification process by removing the oauth2 step. - Add a private web server in /bot that /portal makes a call to after CAS login. - Now, all db handling is done on the /bot side. - Also removes some dead code, and updates README
Also updates package-lock.json
ankith26
force-pushed
the
ankith26-new-verify
branch
from
d90b865
to
2b6cce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a user perspective, this change aims to simplify the verification process by removing one step of the browser-side verification. The Discord OAuth2 mechanism just to read the users discord ID has been removed now (as this information is already available on the
/botside).From a development perspective, here are the changes made in this PR
/botthat/portalmakes a call to after CAS login, supplying the name, email and roll number. Now, all db handling is done on the/botside, as here the Discord ID is known.package.jsonby removing the unneeded things.Dockerfileof/bot