Оптимизации и упрощение кода

OGSR · Mar 14, 2024 · 79e5283 · 79e5283
1 parent f830248
commit 79e5283
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 34 deletions.
diff --git a/ogsr_engine/xrGame/ShootingObject.cpp b/ogsr_engine/xrGame/ShootingObject.cpp
@@ -433,7 +433,7 @@ void CShootingObject::FireBullet(const Fvector& pos, const Fvector& shot_dir, fl
     bool aim_bullet;
     if (m_bUseAimBullet)
     {
-        if (ParentMayHaveAimBullet())
+        if (ParentIsActor())
         {
             if (m_fPredBulletTime == 0.0)
             {

diff --git a/ogsr_engine/xrGame/ShootingObject.h b/ogsr_engine/xrGame/ShootingObject.h
@@ -48,8 +48,7 @@ class CShootingObject
 
 public:
     IC BOOL IsWorking() const { return bWorking; }
-    virtual BOOL ParentMayHaveAimBullet() { return FALSE; }
-    virtual BOOL ParentIsActor() { return FALSE; }
+    virtual bool ParentIsActor() const { return false; }
 
 protected:
     // Weapon fires now

diff --git a/ogsr_engine/xrGame/Weapon.cpp b/ogsr_engine/xrGame/Weapon.cpp
@@ -96,9 +96,6 @@ void CWeapon::UpdateXForm()
     {
         dwXF_Frame = Device.dwFrame;
 
-        if (0 == H_Parent())
-            return;
-
         // Get access to entity and its visual
         CEntityAlive* E = smart_cast<CEntityAlive*>(H_Parent());
 
@@ -112,7 +109,6 @@ void CWeapon::UpdateXForm()
         if (parent->attached(this))
             return;
 
-        R_ASSERT(E);
         IKinematics* V = smart_cast<IKinematics*>(E->Visual());
         VERIFY(V);
 
@@ -128,12 +124,19 @@ void CWeapon::UpdateXForm()
         if (boneL == BI_NONE || boneR == BI_NONE)
             return;
 
-        // от mortan:
-        // https://www.gameru.net/forum/index.php?s=&showtopic=23443&view=findpost&p=1677678
-        V->CalculateBones_Invalidate();
-        V->CalculateBones(true); // V->CalculateBones	();
-        Fmatrix& mL = V->LL_GetTransform(u16(boneL));
-        Fmatrix& mR = V->LL_GetTransform(u16(boneR));
+        if (auto pActor = smart_cast<CActor*>(H_Parent()); pActor && pActor->cam_Active() != pActor->cam_FirstEye())
+        {
+            // https://www.gameru.net/forum/index.php?s=&showtopic=23443&view=findpost&p=1677678
+            V->CalculateBones_Invalidate();
+            V->CalculateBones(true);
+        }
+        else
+        {
+            V->CalculateBones();
+        }
+
+        const Fmatrix& mL = V->LL_GetTransform(u16(boneL));
+        const Fmatrix& mR = V->LL_GetTransform(u16(boneR));
         // Calculate
         Fmatrix mRes;
         Fvector R, D, N;
@@ -2041,24 +2044,9 @@ float CWeapon::GetConditionToShow() const
     return (GetCondition()); // powf(GetCondition(),4.0f));
 }
 
-BOOL CWeapon::ParentMayHaveAimBullet()
+bool CWeapon::ParentIsActor() const
 {
-    CObject* O = H_Parent();
-    if (!O)
-        return FALSE;
-    CEntityAlive* EA = smart_cast<CEntityAlive*>(O);
-    return EA->cast_actor() != 0;
-}
-
-BOOL CWeapon::ParentIsActor()
-{
-    CObject* O = H_Parent();
-    if (!O)
-        return FALSE;
-    CEntityAlive* EA = smart_cast<CEntityAlive*>(O);
-    if (!EA)
-        return FALSE;
-    return EA->cast_actor() != 0;
+    return smart_cast<const CActor*>(H_Parent()) != nullptr;
 }
 
 const float& CWeapon::hit_probability() const

diff --git a/ogsr_engine/xrGame/Weapon.h b/ogsr_engine/xrGame/Weapon.h
@@ -552,8 +552,7 @@ class CWeapon : public CHudItemObject, public CShootingObject
     virtual bool use_crosshair() const { return true; }
     bool show_crosshair();
     bool show_indicators();
-    virtual BOOL ParentMayHaveAimBullet();
-    virtual BOOL ParentIsActor();
+    virtual bool ParentIsActor() const override;
 
 private:
     float m_hit_probability[egdCount];

diff --git a/ogsr_engine/xrGame/ai/stalker/ai_stalker_fire.cpp b/ogsr_engine/xrGame/ai/stalker/ai_stalker_fire.cpp
@@ -674,10 +674,10 @@ float CAI_Stalker::pick_distance()
 
 void CAI_Stalker::update_can_kill_info()
 {
-    if (m_pick_frame_id == Device.dwFrame)
+    if (m_pick_frame_id > Device.dwFrame)
         return;
 
-    m_pick_frame_id = Device.dwFrame;
+    m_pick_frame_id = Device.dwFrame + 10;
     m_can_kill_member = false;
     m_can_kill_enemy = false;