Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Statically linked binary releases #1045

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

bclement-ocp
Copy link
Collaborator

@bclement-ocp bclement-ocp commented Feb 22, 2024

This patch modifies the Docker workflow to build a statically linked portable binary of Alt-Ergo, following [1].

Building the Linux binaries is fairly quick and hence performed on push/pull_request.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/

@bclement-ocp bclement-ocp force-pushed the staticbin branch 2 times, most recently from b683d59 to d3ed734 Compare February 22, 2024 16:12
@bclement-ocp bclement-ocp changed the title WIP: Build static binaries feat: Statically linked binary releases Feb 22, 2024
@bclement-ocp bclement-ocp marked this pull request as ready for review February 22, 2024 16:12
@bclement-ocp bclement-ocp marked this pull request as draft February 23, 2024 10:27
@bclement-ocp
Copy link
Collaborator Author

(Marking as draft because the macOS binaries do not work)

@bclement-ocp bclement-ocp force-pushed the staticbin branch 2 times, most recently from 1229dcb to 21a9058 Compare March 20, 2024 14:20
@bclement-ocp
Copy link
Collaborator Author

Updated to only include static builds for Linux/x86_64 for now, and to build with flambda enabled.

@bclement-ocp bclement-ocp marked this pull request as ready for review March 20, 2024 14:26
@bclement-ocp
Copy link
Collaborator Author

Statically linked x86-64 linux binaries for this PR are here

This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/
@bclement-ocp
Copy link
Collaborator Author

I got access to a macOS machine internally and could debug the macOS build; this is not enabled by default (needs a manual workflow trigger) but is included in this PR now. It was tested separately (see #1067 ).

This should actually be ready for review now :)

@Halbaroth Halbaroth merged commit 0065018 into OCamlPro:next Mar 26, 2024
15 checks passed
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 27, 2024
This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 27, 2024
This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 27, 2024
This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/
Halbaroth pushed a commit that referenced this pull request Mar 28, 2024
* feat: Statically linked binary releases (#1045)

This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/

* TEMP: Test macOS build
Halbaroth pushed a commit to Halbaroth/alt-ergo that referenced this pull request Apr 2, 2024
This patch modifies the Docker workflow to build a statically linked
portable binary of Alt-Ergo, following [1]. This also adds static builds
for macOS on both x86-64 and arm64 platforms.

Building the Linux binaries is fairly quick and hence performed on
push/pull_request. It can also be manually requested. macOS static
builds are much slower and can only be manually requested.

[1] : https://ocamlpro.com/blog/2021_09_02_generating_static_and_portable_executables_with_ocaml/
@bclement-ocp bclement-ocp added this to the 2.6.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants