-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] auth_session_timeout adapt to use websocket instead of longpolling #555
base: 16.0
Are you sure you want to change the base?
Conversation
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot rebase |
Congratulations, PR rebased to 16.0. |
9b05a87
to
e845c6b
Compare
It's been a while. Actually I don't remember. :) In general I think the tests of this module needs to be changed. |
Hm, I looked into it for a bit and in 16.0, Hence I'm not even sure if "ignored_urls" are needed at all. If we wanted to add a unit test, one ideais to do a naive "tour" test - open a headless Chrome browser, set timeout to 1 minute, do nothing but let any browser background calls do their thing, then check whether session has indeed timed out, or if it has been woken up by some websocket call. Of course we could actively simulate such websocket calls as well, that's another option. As for functional experience - are you using this somewhere in production, and does it work? |
Well, I know a few places where it is installed in production. Side note: Currently in the process of becoming an offical partner. Long time ago I did a successfull functional test "Manually" on V16. |
Migration leftover see:
#507 (review)