Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] auth_oidc: Add AzureAD code flow provider #548

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[16.0][IMP] auth_oidc: Add AzureAD code flow provider #548

merged 1 commit into from
Oct 9, 2023

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Aug 22, 2023

For an easier getting started I've updated the documentation and added pre-configured auth providers for Microsoft Azure AD

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos changed the title [IMP] auth_oidc: Add AzureAD code flow provider [16.0][IMP] auth_oidc: Add AzureAD code flow provider Aug 22, 2023
@sbidoul
Copy link
Member

sbidoul commented Oct 4, 2023

@adrienpeiffer could you have a quick look at this one?

adrienpeiffer
adrienpeiffer reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Some questions

auth_oidc/data/auth_oauth_data.xml Outdated Show resolved Hide resolved
auth_oidc/data/auth_oauth_data.xml Show resolved Hide resolved
auth_oidc/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
auth_oidc/readme/CONFIGURE.rst

.. image:: ..static/description/oauth-microsoft_azure-optional_claims.png

* Provider Name: Azure AD Single Tenant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the differences between auth with single or multi ? pros/cons ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sentence sufficient? Or should I add this link as well?
https://learn.microsoft.com/en-us/azure/active-directory/develop/single-and-multi-tenant-apps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine

@CRogos CRogos force-pushed the 16.0-imp-add-azuread-code-flow branch from d87914e to d0c8951 Compare October 9, 2023 11:27
adrienpeiffer
adrienpeiffer approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It's clearer now.

@sbidoul This can be merged

@sbidoul
Copy link
Member

sbidoul commented Oct 9, 2023

Thanks!

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-548-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cb197eb into OCA:16.0 Oct 9, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0513ca2. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 16.0-imp-add-azuread-code-flow branch October 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CRogos @OCA-git-bot @sbidoul @adrienpeiffer