[16.0][MIG] sale_start_end_dates #2577

alexis-via · 2023-06-20T10:18:59Z

Superseeds migration PR #2327 I converted onchange to compute methods.

Replace openerp by odoo in import declarations

Currently translated at 100,0% (16 of 16 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_start_end_dates/nl_NL/

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Convert readme to new subdir format

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/

Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/

Improve and update some strings Update FR translation

alexis-via · 2023-06-20T12:22:17Z

Tests are green!

rousseldenis · 2023-06-21T07:21:36Z

/ocabot migration sale_start_end_dates

OCA-git-bot · 2023-06-21T07:21:45Z

The migration issue (#2215) has not been updated to reference the current pull request because a previous pull request (#2327) is not closed.
Perhaps you should check that there is no duplicate work.
CC @vancouver29

rousseldenis

Code review. Indeed, this is better

dsolanki-initos

Functional review LGTM.

DorianMAG

Thx for this work.
Tested on runboat.
LGTM

agent-z28 · 2023-07-16T15:42:44Z

@alexis-via

I found this:

File "/opt/odoo/auto/addons/sale_start_end_dates/models/sale_order.py", line 184, in _compute_end_date
elif line.end_date and line.start_date and line.start_date > self.end_date:
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1157, in get
self.recompute(record)
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1365, in recompute
apply_except_missing(self.compute_value, recs)
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1338, in apply_except_missing
func(records)
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1387, in compute_value
records._compute_field_value(self)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 4208, in _compute_field_value
fields.determine(field.compute, self)
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 97, in determine
return needle(*args)
File "/opt/odoo/auto/addons/sale_start_end_dates/models/sale_order.py", line 169, in _compute_start_date
elif line.end_date and line.start_date and line.start_date > self.end_date:
File "/opt/odoo/custom/src/odoo/odoo/fields.py", line 1153, in get
record.ensure_one()
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5137, in ensure_one
raise ValueError("Expected singleton: %s" % self)
alueError: Expected singleton: sale.order.line(45, 46, 47, 48)

2 ) I think it would be nice to have an option, to update all lines with a new default_date

Imagine you work with a long sales template which will be pulled as default. So the whole order lines are there.
Now you have to set it in each line manually!

Maybe onchange just fill out all empty values for order.lines that require it!?

DorianMAG · 2023-07-24T10:19:16Z

Hi @agent-z28, @alexis-via
I tried to reproduce the problem,
but I did not find.
Do you have any details on this.
Does this require a fix?

agent-z28 · 2023-07-24T10:26:46Z

Hi @agent-z28, @alexis-via I tried to reproduce the problem, but I did not find. Do you have any details on this. Does this require a fix?

Hi i provided a fix here:

https://github.com/akretion/sale-workflow/pull/29/files#diff-9aa1071ea0fb2a2becdd07b45fcd2f44dd74b8f762e497498c06f298e7a81d33R184

akretion#29

its self instead of line ...

rafaelbn

/ocabot merge patch

OCA-git-bot · 2023-08-07T15:30:21Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2577-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot · 2023-08-07T15:43:49Z

Congratulations, your PR was merged at 25d4208. Thanks a lot for contributing to OCA. ❤️

Alexis de Lattre and others added 30 commits June 20, 2023 10:29

Initial check-in of the rental project.

bc1f045

Port to v8 and new API with several enhancements

68ff857

Slovene translations added

0c33855

OCA Transbot updated translations from Transifex

2cc4c13

Port sale_start_end_dates and sale_rental (OCA#353)

54092c4

sale_start_end_dates and sale_rental

005aa88

Product qty on rental pickings

5fb02bb

Replace openerp by odoo in import declarations

Update sale_start_end_dates.pot

311213d

sale_start_end_dates: Migration to 11.0.

58ef3d4

Update sale_start_end_dates.pot

2261110

Update translation files

8a459b1

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] sale_start_end_dates and sale_rental to v12

1ed9087

Convert readme to new subdir format

[FIX] sale_start_end_dates: bad code in compute method

5a76f06

[UPD] Update sale_start_end_dates.pot

f424875

[UPD] README.rst

76528cf

Translated using Weblate (Portuguese)

dbe129d

Currently translated at 26.7% (4 of 15 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_start_end_dates Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_start_end_dates/pt/

[MIG] sale_start_end_dates to v13

01e28b2

Black/flake8 fight

ea91141

Add maintainers key in manifest

039f89b

[MIG] sale_start_end_dates to v14

bac3871

[UPD] Update sale_start_end_dates.pot

0f526d7

[UPD] README.rst

acc9873

[MIG] sale_start_end_dates to v15

8ae4b58

[UPD] Update sale_start_end_dates.pot

e402a8b

[UPD] README.rst

22515a9

sale_start_end_dates 15.0.1.0.1

4d298bf

[UPD] README.rst

c33fe60

[UPD] README.rst

63ae1a8

vancouver29 added 2 commits June 20, 2023 10:29

[IMP] sale_start_end_dates: pre-commit stuff

d5a1409

[MIG] sale_start_end_dates: Migration to 16.0

8dacdd6

alexis-via mentioned this pull request Jun 20, 2023

[16.0][MIG] sale_start_end_dates #2327

Closed

sale_start_end_dates: onchange -> compute methods

b8ee3b0

Improve and update some strings Update FR translation

alexis-via force-pushed the 16.0-mig-sale_start_end_dates-improve branch from d45fa60 to b8ee3b0 Compare June 20, 2023 11:17

OCA-git-bot added this to the 16.0 milestone Jun 21, 2023

rousseldenis added needs review migration labels Jun 21, 2023

rousseldenis approved these changes Jun 21, 2023

View reviewed changes

dsolanki-initos approved these changes Jun 26, 2023

View reviewed changes

OCA-git-bot added the approved label Jun 26, 2023

DorianMAG approved these changes Jun 26, 2023

View reviewed changes

Fix Singleton Exception (#29)

00da877

rafaelbn approved these changes Aug 7, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 7, 2023

OCA-git-bot merged commit 15b659a into OCA:16.0 Aug 7, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_start_end_dates #2577

[16.0][MIG] sale_start_end_dates #2577

alexis-via commented Jun 20, 2023

alexis-via commented Jun 20, 2023

rousseldenis commented Jun 21, 2023

OCA-git-bot commented Jun 21, 2023

rousseldenis left a comment

dsolanki-initos left a comment

DorianMAG left a comment

agent-z28 commented Jul 16, 2023 •

edited

Loading

DorianMAG commented Jul 24, 2023

agent-z28 commented Jul 24, 2023 •

edited

Loading

rafaelbn left a comment

OCA-git-bot commented Aug 7, 2023

OCA-git-bot commented Aug 7, 2023

[16.0][MIG] sale_start_end_dates #2577

[16.0][MIG] sale_start_end_dates #2577

Conversation

alexis-via commented Jun 20, 2023

alexis-via commented Jun 20, 2023

rousseldenis commented Jun 21, 2023

OCA-git-bot commented Jun 21, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

dsolanki-initos left a comment

Choose a reason for hiding this comment

DorianMAG left a comment

Choose a reason for hiding this comment

agent-z28 commented Jul 16, 2023 • edited Loading

DorianMAG commented Jul 24, 2023

agent-z28 commented Jul 24, 2023 • edited Loading

rafaelbn left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 7, 2023

OCA-git-bot commented Aug 7, 2023

agent-z28 commented Jul 16, 2023 •

edited

Loading

agent-z28 commented Jul 24, 2023 •

edited

Loading