Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] purchase_reception_status_line #2434

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

DavidJForgeFlow
Copy link
Contributor

This module works with purchase_reception_status by adding the "force reception" check from the PO to the PO line.
This gives more flexibility when forcing some quantities.

@ForgeFlow

@DavidJForgeFlow DavidJForgeFlow force-pushed the 15.0-add-purchase_reption_status_line branch from bb5267f to 73cfa20 Compare October 14, 2024 10:42
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. What would you think of purchase_line_reception_status as a module name instead of purchase_reception_status_line? And please add a test.

@DavidJForgeFlow
Copy link
Contributor Author

Hi @StefanRijnhart,
My idea with the name was maintain the two related modules purchase_reception_status and purchase_reception_status_line consecutive in the modules list to make easier to know that are related. Changing the naming will remove this relation and split them in the list. What do you think about that?
And I will add tests ASAP.

@StefanRijnhart
Copy link
Member

@DavidJForgeFlow I guess that makes sense as well.

@DavidJForgeFlow DavidJForgeFlow force-pushed the 15.0-add-purchase_reption_status_line branch from 73cfa20 to 82d58c4 Compare October 23, 2024 09:50
@DavidJForgeFlow
Copy link
Contributor Author

@StefanRijnhart tests done!

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

@DavidJForgeFlow DavidJForgeFlow force-pushed the 15.0-add-purchase_reption_status_line branch from 82d58c4 to 3a15e70 Compare October 24, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants