Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][18.0] [mig] quality_control_oca: Migrated the module #1374

Open
wants to merge 106 commits into
base: 18.0
Choose a base branch
from
Open

[WIP][18.0] [mig] quality_control_oca: Migrated the module #1374

wants to merge 106 commits into from

Conversation

Trivedi-Vacha-SerpentCS
Copy link

No description provided.

oihane and others added 30 commits October 23, 2024 14:57
@oihane @Trivedi-Vacha-SerpentCS
Modulos de calidad sin migrar
5975c65
@pedrobaeza @Trivedi-Vacha-SerpentCS
quality_control * PEP8 * Travis * Size in field (deprecated)
7139f6a
@alfredoavanzosc @Trivedi-Vacha-SerpentCS
no msg
bd1ec52
@pedrobaeza @Trivedi-Vacha-SerpentCS
quality_control: Some improvement
32f6625
@oihane @Trivedi-Vacha-SerpentCS
<quality_control> deleted constraint
d2a1a01
@pedrobaeza @Trivedi-Vacha-SerpentCS
quality_control: Total refactorization with new API, README files, an…
4579085 
…d new concepts. * Triggers for product category * ACLs * Tolerances in questions * one2many copyable * Fix some views * Error on same tolerance * Colors on inspection lines * Unify inspection header data assignment in set_test method * key name in set_test * Change icon set
@oihane @Trivedi-Vacha-SerpentCS
New module <quality_control_hr> closes OCA#662 * Changes in access ru…
c9eae29 
…les * Trigger line instead of test and user
@pedrobaeza @Trivedi-Vacha-SerpentCS
quality_control * Fix wizard set test
afd1c25 
* Expand AUTHORS

* Fix permissions
@ejans @Trivedi-Vacha-SerpentCS
changed default references of fields.Datetime.now() to fields.Datetim…
cc54ad7 
…e.now
@sysadminmatmoz @Trivedi-Vacha-SerpentCS
Slovene translations added
6d7d597
@oihane @Trivedi-Vacha-SerpentCS
quality_control: * Changed permissions
68b133c 
* security modified
* some demo info added
* Added "partner_selectable" field, so that inspections can by made by partner
* Little view fixing, field was oe_edit_only instead of label
* Add partners to trigger lines
* Tests added
* Trigger lines with duplicated test cleaned

quality_control: Propose to OCA

quality_control: required changes

quality_control: Fixing coveralls

quality_control_stock: * added demo data * replaced unlink method by ondelete="cascade" * required changes
@pedrobaeza @Trivedi-Vacha-SerpentCS
quality_control_*: Make use of qty field
0347265 
Making it a regular field, you can put any manual quantity in inspections
@oihane @Trivedi-Vacha-SerpentCS
quality_control: deleting qc.inspection does not delete its lines fixed
6f4b01b
@Trivedi-Vacha-SerpentCS
[IMP] quality_control: decimal precision configurable + approving ins…
a0cbe4b 
…pections only by quality control managers
@LoisRForgeFlow @Trivedi-Vacha-SerpentCS
[9.0][MIG] quality_control
f1eb06b
@Trivedi-Vacha-SerpentCS
[FIX] quality_control: Several things:
4c7c943 
* not take into account inactivated tests trigger lines
* show action_cancel button in inspections even if it is autogenerated
@zamberjo @Trivedi-Vacha-SerpentCS
[FIX] quality_control: Fix TypeError on new test category (OCA#193)
b83f09e 
`TestQualityControl` is failing on `QcTestTemplateCatergory._get_complete_name`
when `name` is set as `False`.
@LoisRForgeFlow @Trivedi-Vacha-SerpentCS
[9.0][FIX] quality_control: use odoo tag on views
1bcdc2d
@SimoRubi @Trivedi-Vacha-SerpentCS
[MIG] quality_control: Migration to 10.0
330751f
@Trivedi-Vacha-SerpentCS
[MIG] quality_control: Migration to 11.0
13404dc
@SalahAdDin @Trivedi-Vacha-SerpentCS
[11.0][FIX] quality_control: Fixed dashboard icon. (OCA#304)
a3b3bbb
@LoisRForgeFlow @Trivedi-Vacha-SerpentCS
[10.0][FIX] quality_control: move quality control configuration menu …
05827fa 
…to quality_control module to avoid runbot warning
@oihane @Trivedi-Vacha-SerpentCS
[FIX] quality_control: created new notebook page to avoid activate va…
d907f31 
…riants + permissions (OCA#325)
@pedrobaeza @Trivedi-Vacha-SerpentCS
[IMP] quality_control: App drawer icon
580c796
@NachoAlesLopez @Trivedi-Vacha-SerpentCS
[MIG] quality_control: Migration to 12.0
c83a915
@LoisRForgeFlow @Trivedi-Vacha-SerpentCS
[12.0][FIX] quality_control: add user admin to quality control manage…
9045a6a 
…r group by default.
@Trivedi-Vacha-SerpentCS
[UPD] Update module logo
8121a13
@pedrocs-exo @Trivedi-Vacha-SerpentCS
Translated using Weblate (Portuguese)
1cf907a 
Currently translated at 98.1% (154 of 157 strings)

Translation: manufacture-12.0/manufacture-12.0-quality_control
Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/pt/
@NachoAlesLopez @Trivedi-Vacha-SerpentCS
[FIX] quality_control
5ae912f 
Fixed Quality Control Trigger 'trigger' selector in Product Template and Product Category.
@badbole @Trivedi-Vacha-SerpentCS
Translated using Weblate (Croatian)
6b2b22c 
Currently translated at 77.1% (121 of 157 strings)

Translation: manufacture-12.0/manufacture-12.0-quality_control
Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-quality_control/hr/
mymage and others added 25 commits October 23, 2024 14:57
@mymage @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
f3319b3 
Currently translated at 100.0% (163 of 163 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@Ivorra78 @Trivedi-Vacha-SerpentCS
Translated using Weblate (Spanish)
a65de19 
Currently translated at 100.0% (163 of 163 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/es/
@francesco-ooops @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
3a2d835 
Currently translated at 100.0% (163 of 163 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@mymage @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
03f2485 
Currently translated at 100.0% (163 of 163 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@francesco-ooops @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
dc37028 
Currently translated at 100.0% (163 of 163 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@Trivedi-Vacha-SerpentCS
[UPD] Update quality_control_oca.pot
924265f
@weblate @Trivedi-Vacha-SerpentCS
Update translation files
1bd31bf 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/
@mymage @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
8e52223 
Currently translated at 100.0% (162 of 162 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@mymage @Trivedi-Vacha-SerpentCS
Translated using Weblate (Italian)
bf6df08 
Currently translated at 100.0% (162 of 162 strings)

Translation: manufacture-16.0/manufacture-16.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-quality_control_oca/it/
@pedrobaeza @Trivedi-Vacha-SerpentCS
[FIX] quality_control_oca: XML-ID must be fully qualified
1f79a16 
Fixes OCA#1167
@OCA-git-bot @Trivedi-Vacha-SerpentCS
[BOT] post-merge updates
5aaf698
@angelmoya @Trivedi-Vacha-SerpentCS
[MIG] quality_control_stock_oca: Migration to 16.0
21d3769
@victoralmau @Trivedi-Vacha-SerpentCS
[MIG] quality_control_stock_oca: Migration to 16.0
91c2c9f 
TT47858
@uolaizola @Trivedi-Vacha-SerpentCS
[FIX] quality_control_oca add colspan attribute to show the inline tr…
11e1da1 
…ee view of the fields correctly
@OCA-git-bot @Trivedi-Vacha-SerpentCS
[BOT] post-merge updates
558b0b4
@peluko00 @Trivedi-Vacha-SerpentCS
[IMP] quality_control_oca: pre-commit auto fixes
c1ef6bf
@peluko00 @Trivedi-Vacha-SerpentCS
[MIG] quality_control_oca: Migration to 17.0
8195eab
@Trivedi-Vacha-SerpentCS
[UPD] Update quality_control_oca.pot
c8fb12e
@OCA-git-bot @Trivedi-Vacha-SerpentCS
[BOT] post-merge updates
28e210d
@jakobkrabbe @Trivedi-Vacha-SerpentCS
Translated using Weblate (Swedish)
7e4cddc 
Currently translated at 100.0% (162 of 162 strings)

Translation: manufacture-17.0/manufacture-17.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-quality_control_oca/sv/
@Trivedi-Vacha-SerpentCS
[UPD] Update quality_control_oca.pot
cda236e
@weblate @Trivedi-Vacha-SerpentCS
Update translation files
6517f4d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-17.0/manufacture-17.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-quality_control_oca/
@jans23 @Trivedi-Vacha-SerpentCS
Translated using Weblate (German)
a1de63a 
Currently translated at 74.3% (119 of 160 strings)

Translation: manufacture-17.0/manufacture-17.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-quality_control_oca/de/
@Trivedi-Vacha-SerpentCS
[UPD] Update quality_control_oca.pot
01fc106
@weblate @Trivedi-Vacha-SerpentCS
Update translation files
a37abea 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-17.0/manufacture-17.0-quality_control_oca
Translate-URL: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-quality_control_oca/
@Trivedi-Vacha-SerpentCS Trivedi-Vacha-SerpentCS changed the title [18.0] [mig] quality_control_oca: Migrated the module [WIP][18.0] [mig] quality_control_oca: Migrated the module Oct 23, 2024
@peluko00
Copy link
Contributor

Please follow oca migration commits convention and squash all commits

@peluko00 peluko00 mentioned this pull request Nov 11, 2024
Open
ppyczko
ppyczko suggested changes Nov 12, 2024
View reviewed changes
quality_control_oca/models/qc_inspection.py
# Copyright 2017 Simone Rubino - Agile Business Group
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo import _, api, exceptions, fields, models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the translation import (_)

quality_control_oca/models/qc_inspection.py
for inspection in self:
if inspection.auto_generated:
raise exceptions.UserError(
_("You cannot remove an auto-generated inspection.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And replace all of the calls to translate a string (_) with self.env._

quality_control_oca/models/qc_inspection.py
)
if inspection.state != "draft":
raise exceptions.UserError(
_("You cannot remove an inspection that is not in draft state.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_inspection.py
def action_todo(self):
for inspection in self:
if not inspection.test:
raise exceptions.UserError(_("You must first set the test to perform."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_inspection.py
for line in inspection.inspection_lines:
if line.question_type == "qualitative" and not line.qualitative_value:
raise exceptions.UserError(
_(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_test.py
and not tc.ql_values.filtered("ok")
):
raise exceptions.ValidationError(
_(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_test.py
for tc in self:
if tc.type == "quantitative" and tc.min_value > tc.max_value:
raise exceptions.ValidationError(
_(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_test_category.py
def _check_parent_id(self):
if self._has_cycle():
raise exceptions.UserError(
_("Error! You can not create recursive categories.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_test.py
# Copyright 2017 Simone Rubino - Agile Business Group
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo import _, api, exceptions, fields, models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

quality_control_oca/models/qc_test_category.py
# Copyright 2017 Simone Rubino - Agile Business Group
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from odoo import _, api, exceptions, fields, models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.