Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] mrp_multi_level: better logs during calculation #1336

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[16.0][IMP] mrp_multi_level: better logs during calculation #1336

merged 1 commit into from
Aug 28, 2024

Conversation

LoisRForgeFlow
Copy link
Contributor

  • Explicitly log which area and LLC is being computed.
  • Correct LLC being logged.

@OCA-git-bot
Copy link
Contributor

Hi @JordiBForgeFlow, @ChrisOForgeFlow,
some modules you are maintaining are being modified, check this out!

@LoisRForgeFlow
[IMP] mrp_multi_level: better logs during calculation
b4da05c 
* Explicitly log which area and LLC is being computed.
* Correct LLC being logged.
@LoisRForgeFlow LoisRForgeFlow force-pushed the 16.0-imp-mrp_multi_level-calc-logs branch from fc38439 to b4da05c Compare August 14, 2024 14:14
ChrisOForgeFlow
ChrisOForgeFlow approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1336-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ed65d0d into OCA:16.0 Aug 28, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 49a41be. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-imp-mrp_multi_level-calc-logs branch August 28, 2024 13:23
This was referenced Aug 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisOForgeFlow ChrisOForgeFlow ChrisOForgeFlow approved these changes

@gbrito gbrito gbrito approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LoisRForgeFlow @OCA-git-bot @gbrito @ChrisOForgeFlow