-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] mrp_bom_produce_delay #1241
base: 16.0
Are you sure you want to change the base?
Conversation
ba53933
to
a9dae4e
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
ping @OCA/manufacturing-maintainers what do you think of this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String deal
<field name="inherit_id" ref="mrp.mrp_bom_form_view" /> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='product_id']" position="after"> | ||
<label for="produce_delay" string="Product Manuf. Lead Time" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<label for="produce_delay" string="Product Manuf. Lead Time" /> | |
<label for="produce_delay" string="Lead Time" /> |
It avoid to have a string split in 2 lines and we know it's about product and manufacture because it's in bom view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as 1st comment, i took the term of the core field "produce_delay". But I agree with you that i can change the string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes in product form you need string 'Manuf' because there are many purposes but in bom view manufacture vocabulary is implicit, don't repeat yourself, KISS.
class MrpBom(models.Model): | ||
_inherit = "mrp.bom" | ||
|
||
produce_delay = fields.Float( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
produce_delay = fields.Float( | |
lead_time = fields.Float( |
delay is "retard" !?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
produce_delay is the field in MRP in Product model !
I also don't understand it's technical english name (delay is "retard" in FR) but the help message is more clear
That why i take the logic of the core field : https://github.com/odoo/odoo/blob/16.0/addons/mrp/models/product.py#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for technical name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify the behaviour when a product as multiple boms (active or not) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want block, but in case of many boms by product, the behavior could be unexpected for some flows.
On my side, for the same needs I would just use a related readonly field.
But it works as it
This PR has the |
This module is designed to better respond to the flow of certain users who think about their production time when creating a bill of materials.
It adds
Product Delay
in BoM, and changes in BoM field will affect ProductProduce Delay
.