Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] mrp_helper: Add methods shared between various mrp modules #1074

Closed
wants to merge 1 commit into from
Closed

[14.0][ADD] mrp_helper: Add methods shared between various mrp modules #1074

wants to merge 1 commit into from

Conversation

mt-software-de
Copy link

@mt-software-de mt-software-de commented Aug 7, 2023 •
edited
Loading

This PR is adding a new module called mrp_helper to share some useful methods between various mrp modules.
In fact now it only adds the possibility to ignore the _bom_find method of mrp.bom.

@mt-software-de mt-software-de changed the title [ADD] mrp_helper: Add methods shared between various mrp modules [14.0][ADD] mrp_helper: Add methods shared between various mrp modules Nov 6, 2023
@mt-software-de
Copy link
Author

Maybe @jaredkipe you want also review this one?

@mt-software-de
Copy link
Author

@grindtildeath, @LoisRForgeFlow could review this one, whats your opinion about this?

@grindtildeath
Copy link
Contributor

@mt-software-de Thanks for the contribution.

I would suggest to call the module something like mrp_bom_find_ignore to reflect what it's actually doing and set a development status to alpha.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@github-actions github-actions bot closed this Apr 28, 2024
@mt-software-de
Copy link
Author

@OCA/manufacturing-maintainers can anyone please reopen this PR?

@mt-software-de mt-software-de mentioned this pull request Sep 10, 2024
Merged
@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Sep 10, 2024 •
edited
Loading

@mt-software-de it cannot be reopened because the "branch was force-pushed or recreated".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mt-software-de @grindtildeath @LoisRForgeFlow