Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] maintenance_plan: Create requests from a domain #357

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[14.0][IMP] maintenance_plan: Create requests from a domain #357

merged 1 commit into from
Oct 23, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Sep 6, 2023

This PR Allows us to create several requests from a single plan using a domain to set several equipments.

For example, I create a plan for callibration of all the equipments for category Monitor. Then, at the specified time, for all the active monitors in my sistem, a callibration action will be generated.

@LoisRForgeFlow
Copy link
Contributor

@etobella I think this can be included in the base maintenance_plan module, I don't see any problem for existing instalation, you can just not use the feature.

@etobella etobella changed the title [14.0][ADD] maintenance_plan_domain [14.0][IMP] maintenance_plan: Create requests from a domain Sep 22, 2023
@etobella
Copy link
Member Author

Tests are 🍏 @LoisRForgeFlow May I ask for your review?

LoisRForgeFlow
LoisRForgeFlow reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a really interesting improvement!

One suggestion to improve UX. What do you think about adding a computed field that links domain based plans with applicable equipments in a way that you can find from an equipment which plan would apply to it?

@etobella
Copy link
Member Author

It would be hard to manage it by a widget (problems with creation), but, I could do a button that opens all the plans of an equipment. WDYT?

@LoisRForgeFlow
Copy link
Contributor

It would be hard to manage it by a widget (problems with creation), but, I could do a button that opens all the plans of an equipment. WDYT?

I think that would be great!

@etobella etobella mentioned this pull request Oct 18, 2023
Merged
LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etobella
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-357-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 331a109 into OCA:14.0 Oct 23, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cd45608. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etobella @LoisRForgeFlow @OCA-git-bot