Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] edi_account_oca #15

Merged
merged 26 commits into from
Oct 17, 2023
Merged

[16.0][MIG] edi_account_oca #15

merged 26 commits into from
Oct 17, 2023

Conversation

OriolMForgeFlow
Copy link
Contributor

@OriolMForgeFlow OriolMForgeFlow commented Aug 1, 2023 •
edited
Loading

Moved from edi repository. Standard migration.

@OriolMForgeFlow OriolMForgeFlow changed the title [16.0][MIG] edi_account_ oca [WIP][16.0][MIG] edi_account_ oca Aug 9, 2023
@OriolMForgeFlow OriolMForgeFlow marked this pull request as draft August 11, 2023 09:11
@OriolMForgeFlow
Copy link
Contributor Author

HI @simahawk ,
I was wondering if you could take a look at this. The error I commented on in the previous PR, with the debug assets enabled, is as follows:

Screenshot from 2023-10-03 09-10-57

It appears when installing the 'edi_account_oca' module and you try to open the Invoicing app.

@simahawk
Copy link
Contributor

simahawk commented Oct 3, 2023

Here's the fix #23

@OriolMForgeFlow OriolMForgeFlow force-pushed the 16.0-mig-edi_account_oca branch 2 times, most recently from 2c07748 to f538c70 Compare October 4, 2023 07:29
@OriolMForgeFlow
Copy link
Contributor Author

Here's the fix #23

Thank you very much, @simahawk! 😄

This solution resolved the issue with rendering the view. However, a new problem has arisen: the view now appears somewhat disorganized. I also attempted to migrate edi_stock_oca and encountered the same issue.

Examples:

Screenshot from 2023-10-04 09-27-32

Screenshot from 2023-10-04 09-45-28

@simahawk
Copy link
Contributor

Ok, it seems we have to find a better position where to place the buttons.

@etobella
Copy link
Member

@OriolMForgeFlow Can you test how it works with this?

#29

On my local repository worked fine

image

@simahawk simahawk mentioned this pull request Oct 17, 2023
Merged
@OriolMForgeFlow OriolMForgeFlow marked this pull request as ready for review October 17, 2023 07:32
@OriolMForgeFlow OriolMForgeFlow changed the title [WIP][16.0][MIG] edi_account_ oca [16.0][MIG] edi_account_ oca Oct 17, 2023
@OriolMForgeFlow
Copy link
Contributor Author

@OriolMForgeFlow Can you test how it works with this?

#29

On my local repository worked fine

image

Worked correctly @etobella! When #29 is merged, this PR can also be reviewed.

@etobella
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@etobella The rebase process failed, because command git push --force ForgeFlow tmp-pr-15:16.0-mig-edi_account_oca failed with output:

remote: Permission to ForgeFlow/edi-framework.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/edi-framework/': The requested URL returned error: 403

etobella and others added 14 commits October 17, 2023 11:41
oca-ci and others added 12 commits October 17, 2023 11:41
@OriolMForgeFlow
[UPD] Update edi_account_oca.pot
137f329
@OCA-git-bot @OriolMForgeFlow
edi_account_oca 14.0.1.1.0
00a5b1f
@oca-transbot @OriolMForgeFlow
Update translation files
6df3817 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-14.0/edi-14.0-edi_account_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-edi_account_oca/
@ao-landoo @OriolMForgeFlow
[MIG] edi_account_oca: Migration to 15.0
51685c7
@OriolMForgeFlow
[UPD] Update edi_account_oca.pot
f259e77
@OCA-git-bot @OriolMForgeFlow
[UPD] README.rst
dcadaeb
@etobella @OriolMForgeFlow
[FIX] edi_account_oca: Tests failing
24853ea
@OCA-git-bot @OriolMForgeFlow
edi_account_oca 15.0.1.0.1
f52ddb5
@OriolMForgeFlow
[UPD] Update edi_account_oca.pot
cdc62de
@weblate @OriolMForgeFlow
Update translation files
e637b3c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-15.0/edi-15.0-edi_account_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_account_oca/
@OriolMForgeFlow
[IMP] edi_account_oca: pre-commit stuff
2cb384f
@OriolMForgeFlow
[MIG] edi_account_oca: Migration to 16.0
6a3368a
etobella
etobella approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looked great

👍

@pedrobaeza pedrobaeza changed the title [16.0][MIG] edi_account_ oca [16.0][MIG] edi_account_oca Oct 17, 2023
@pedrobaeza
Copy link
Member

/ocabot migration edi_account_oca

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 17, 2023
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-15-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5112a93 into OCA:16.0 Oct 17, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d8cd6d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@OriolMForgeFlow @simahawk @etobella @OCA-git-bot @pedrobaeza @oca-travis @Yvesldff @oca-transbot @ao-landoo @weblate