Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FW] edi_oca: missing FW from 16.0 #118

Open
wants to merge 37 commits into
base: 17.0
Choose a base branch
from

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Oct 24, 2024

In the migration to V17 several commits were left behind in V16.

Depends on OCA/queue#705

CC @etobella @simahawk

tuantrantg and others added 14 commits October 24, 2024 09:23
Avoid warning because of duplicated Model field name while installing this module
Archived rules were not visible on the exc type form.
You can now toggle archived/unarchived directly from exc type form
Send jobs might fail due to an external service being not responsive.
If the job is simply failed, a new one will be spawned and might encour in the same error again,
possibly leading to an high number of duplicated jobs for the same record.

Yet, when a RetryableJobError is raised, the job will be set back into pending state
and will be nicely retried based on jobs configuration.
When actions are automated, is nice to see that data has been generated for an exchange on the related record.
The recommended way to execute actions on records
is to call `action_exchange_*` on
@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

Instead of waiting for the cron to pass again and send the file
chain the 2 jobs so that it gets sent right after generation.
* catch OSError
* add debug log
simahawk and others added 6 commits October 24, 2024 11:30
Prevents having duplicated jobs for the same record as far as possible.
Try to send out the file as fast as possible once the content is ready.
The origin record should never been copied.
Its values should always be set specifically by a framework action.
sebalix and others added 12 commits October 24, 2024 11:30
this field can be used in backend views to show/hide configuration elements depending on the backend type
Currently when we receive an empty file:

- Receive step doesn't end up in state error_on_receive : that's because we just ignore the content here
- But the process step will raise an error
- So this commit goal tries to improve that
- By default, this option is disabled so we still consider that an empty file is an error case
@JordiMForgeFlow
Copy link
Contributor Author

@simahawk @etobella @MiquelRForgeFlow ready for review :)

@simahawk
Copy link
Contributor

@JordiMForgeFlow LG. Could you please update the blacklist of PRs?
If you are not using oca-port you can update the file manually, like https://github.com/OCA/edi/blob/14.0/.oca/oca-port/blacklist/edi_oca.json

@JordiMForgeFlow
Copy link
Contributor Author

@simahawk what is expected to be included in this blacklist? The PRs that have been FW?

@simahawk
Copy link
Contributor

My bad. Short answer is: no. Lemme rephrase: is there any PR that shouldn't be fwd ported or that has been partially fwd ported here (eg: leaving behind irrelevant commits)? If yes, we should blacklist them to not get bothered the next time we run oca-port to check what's needed to be ported.
Hope is clear now! 😊

@JordiMForgeFlow
Copy link
Contributor Author

@simahawk Then I don't think we need to add anything, as I have included everything that was missing from V16. I actually also included them in the V18 migration PR: #115

I can see you merged #93 a couple of days ago, I could add it here as well if it looks good to you :)

@simahawk
Copy link
Contributor

@JordiMForgeFlow ok, beautiful!
#93 can be included, definitely. Thanks!

@JordiMForgeFlow
Copy link
Contributor Author

@simahawk we will need to have OCA/edi#1071 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.