Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] edi_oca: improve error in order to be helpful (forward port) #106

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[16.0][FIX] edi_oca: improve error in order to be helpful (forward port) #106

merged 1 commit into from
Oct 7, 2024
+8 −2

Conversation

MiquelRForgeFlow
Copy link
Contributor

Forward port of OCA/edi#1031.

@OCA-git-bot
Copy link
Contributor

Hi @etobella, @simahawk,
some modules you are maintaining are being modified, check this out!

john-herholz-dt
john-herholz-dt approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella
etobella approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-106-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ff73c9b into OCA:16.0 Oct 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7611f6c. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-edi-imp-error branch October 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-herholz-dt john-herholz-dt john-herholz-dt approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@etobella etobella etobella approved these changes

@rvalyi rvalyi rvalyi approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MiquelRForgeFlow @OCA-git-bot @rvalyi @etobella @JordiMForgeFlow @john-herholz-dt