[16.0][ADD] edi_utm_oca #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
4 times, most recently
from
d48eb79
to
8f08d7c
Compare
simahawk
requested changes
Aug 9, 2024
There was a problem hiding this comment.
As reported on the base PR I don't think we need yet another source discriminator.
We already have endpoint and storage as sources + the types, what else do we need?
Plus, we can leverage UTM for a more general classification... I fail to understand what's the whole point of this.
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
6 times, most recently
from
93b238a
to
8905e1e
Compare
simahawk
reviewed
Aug 30, 2024
simahawk
requested changes
Aug 30, 2024
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
from
8905e1e
to
19cdddd
Compare
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
from
19cdddd
to
9a03816
Compare
simahawk
requested changes
Sep 9, 2024
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
2 times, most recently
from
48fa939
to
b1a2508
Compare
santostelmo
approved these changes
Sep 12, 2024
chaule97
force-pushed
the
16.0-add_edi_sale_utm_oca
branch
from
b1a2508
to
e26ee0e
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 99ad214. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edi_utm_ocaautomatically sets the EDI source on models that have a source_id field when they are created.