Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] hr_timesheet_analytic_tag: Migration to 18.0 #711

Open
wants to merge 10 commits into
base: 18.0
Choose a base branch
from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Nov 20, 2024

@peluko00 peluko00 mentioned this pull request Nov 20, 2024
8 tasks
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peluko00 peluko00 force-pushed the 18.0-mig-hr_timesheet_analytic_tag branch 2 times, most recently from bb145b5 to 7bbbdeb Compare November 22, 2024 07:06
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@@ -63,27 +63,23 @@ def _create_hr_timesheet(self):
)

def test_hr_timesheet_without_tags(self):
self.task.analytic_account_id = self.analytic_account_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v18 this field was removed from project.task model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but then, analytic_account_1 is never used. If not needed, remove its creation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks!

@peluko00 peluko00 force-pushed the 18.0-mig-hr_timesheet_analytic_tag branch from 7bbbdeb to 01aaa6a Compare November 26, 2024 09:38
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants