-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] hr_timesheet_analytic_tag: Migration to 18.0 #711
base: 18.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-16.0/account-analytic-16.0-hr_timesheet_analytic_tag Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-hr_timesheet_analytic_tag/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bb145b5
to
7bbbdeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
@@ -63,27 +63,23 @@ def _create_hr_timesheet(self): | |||
) | |||
|
|||
def test_hr_timesheet_without_tags(self): | |||
self.task.analytic_account_id = self.analytic_account_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v18 this field was removed from project.task
model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but then, analytic_account_1
is never used. If not needed, remove its creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks!
7bbbdeb
to
01aaa6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration hr_timesheet_analytic_tag
/ocabot merge nobump
/ocabot migration hr_timesheet_analytic_tag |
Module migrated to version 18.0
cc https://github.com/APSL 163679
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review
Depends on: