[17.0][MIG] purchase_request_analytic: Migration to 17.0 #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP]add tests
…hase request when all the lines have same analytic account id. Before this change the analytic account is empty in those cases, and because of that, the search of purchase request by analytic account is not working
StefanRijnhart
force-pushed
the
17.0-mig-purchase_request_analytic
branch
2 times, most recently
from
fcb7aeb
to
5ddaadf
Compare
StefanRijnhart
force-pushed
the
17.0-mig-purchase_request_analytic
branch
from
5ddaadf
to
e67cda7
Compare
|
@StefanRijnhart Thanks. Maybe changes could have been put in separate commit in order to be backported ? |
|
@rousseldenis I don't have time for that but it should be easy for the person who requires the module to work on 16.0 |
|
/ocabot migration purchase_request_analytic |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lack of a 16.0 version, the migration from analytic_account_id to analytic_distribution is done here.