Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] analytic_partner: Migration to version 15.0 #573

Merged
merged 18 commits into from
Aug 9, 2023
Merged

[15.0][MIG] analytic_partner: Migration to version 15.0 #573

merged 18 commits into from
Aug 9, 2023

Conversation

stefan-tecnativa
Copy link

cc @Tecnativa TT44155

@pedrobaeza please review!

This PR superseeds #515

pedrobaeza and others added 17 commits July 12, 2023 10:29
@pedrobaeza @stefan-tecnativa
[ADD] analytic_partner
5f40be0 
Classify analytic items by partner
==================================

This module adds a partner on each analytic item for allowing to have another
dimension for analysing data.

It also handles the proper propagation of this field to the created analytic
entries when validating invoices.

Configuration
=============

You have to be granted as at least "Accountant" in your user profile and
have checked the "Analytic Accounting" access right.

Usage
=====

Go to Accounting > Analytic Journal Items, and there, you can set the partner
for the analytic items, and search or group by it.

You can also go to a partner, and click on the smart-button "Cost/Revenue",
placed on the upper-right part, and you will navigate to the analytic items
associated to this partner.

Known issues / Roadmap
======================

* This module hasn't been tested with *account_analytic_plans* module
installed, so maybe it's incompatible with it.
@pedrobaeza @stefan-tecnativa
[FIX+IMP] analytic_partner:
1dbebed 
* IMP: Distinguish between the partner of the account and the specific partner
* FIX: Allow grouping on partner_id field. Fixes OCA#41
* FIX: README - Indentation is not correct in Known issues.
@luismontalba @stefan-tecnativa
[MIG] analytic_account: Migrated to 10.0
61866f3
@cristinamartinrod @stefan-tecnativa
[11.0][MIG] analytic_partner: Migration to 11.0
fe2330e
@sergio-teruel @stefan-tecnativa
[MIG] analytic_partner: Migration to 12.0
b6cfaef
@mvrodriguez @stefan-tecnativa
Translated using Weblate (Galician)
60e982b 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/gl/
@stefan-tecnativa
Translated using Weblate (Catalan)
66e8178 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/ca/
@marcelsavegnago @stefan-tecnativa
Translated using Weblate (Portuguese (Brazil))
eb1e76d 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/pt_BR/
@liweijie0812 @stefan-tecnativa
Translated using Weblate (Chinese (Simplified))
908ea86 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-12.0/account-analytic-12.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-analytic_partner/zh_CN/
@ps-tubtim @stefan-tecnativa
[IMP] analytic_partner: black, isort
469a16a
@ps-tubtim @stefan-tecnativa
[MIG] analytic_partner: Migration to 13.0
35eb883
@CarlosRoca13 @stefan-tecnativa
[IMP] analytic_partner: black, isort
611a550
@CarlosRoca13 @stefan-tecnativa
[MIG] analytic_partner: Migration to v14.0
e998bb6
@Yvesldff @stefan-tecnativa
Added translation using Weblate (French (France))
e6c4f1c
@Yvesldff @stefan-tecnativa
Translated using Weblate (French)
6ee2466 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-analytic-14.0/account-analytic-14.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-analytic_partner/fr/
@Yvesldff @stefan-tecnativa
Translated using Weblate (French (France))
21875d4 
Currently translated at 87.5% (7 of 8 strings)

Translation: account-analytic-14.0/account-analytic-14.0-analytic_partner
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-analytic_partner/fr_FR/
@bizzappdev @stefan-tecnativa
[IMP]analytic_partner: black, isort, prettier
c0e8a16
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-analytic_partner-BAD-TUG branch from ee05e3f to 4fc7602 Compare July 12, 2023 08:29
@pedrobaeza
Copy link
Member

/ocabot migration analytic_partner

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jul 13, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#404) has not been updated to reference the current pull request because a previous pull request (#515) is not closed.
Perhaps you should check that there is no duplicate work.
CC @bizzappdev

@pedrobaeza pedrobaeza mentioned this pull request Jul 13, 2023
Closed
@pedrobaeza
Copy link
Member

The text for co-authorship is not correct. It should be Co-authored-by (it can serve any casing), not Co-Authored By.

https://docs.github.com/es/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@pedrobaeza
Copy link
Member

/ocabot migration analytic_partner

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 1, 2023
Closed
21 tasks
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-analytic_partner-BAD-TUG branch from 4fc7602 to 245aee2 Compare July 13, 2023 07:16
@stefan-tecnativa
Copy link
Author

The text for co-authorship is not correct. It should be Co-authored-by (it can serve any casing), not Co-Authored By.

https://docs.github.com/es/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Reviewed. Thanks for the reference.

@stefan-tecnativa
Copy link
Author

Is this ready to merge? @pedrobaeza

pedrobaeza
pedrobaeza requested changes Aug 8, 2023
View reviewed changes
analytic_partner/README.rst Outdated Show resolved Hide resolved
analytic_partner/__manifest__.py Outdated Show resolved Hide resolved
analytic_partner/readme/CONFIGURE.rst Outdated Show resolved Hide resolved
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-analytic_partner-BAD-TUG branch from 245aee2 to b0bf2cd Compare August 8, 2023 05:55
chienandalu
chienandalu reviewed Aug 9, 2023
View reviewed changes
analytic_partner/readme/CONFIGURE.rst Outdated
Comment on lines 4 to 6
Search "Show Full Accounting Features".
Make sure your user is included in such group.
Do the same for "Analytic Accounting" group.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to numbered bullets?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I put them that way: #573 (comment)

Why removing them, @stefan-tecnativa ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't paid attention to it, sorry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still incorrect, as there are too much spaces in between.

@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-analytic_partner-BAD-TUG branch from b0bf2cd to 864813d Compare August 9, 2023 06:50
@bizzappdev @stefan-tecnativa
[MIG][15.0]analytic_partner:Migration to 15.0
a964622 
Co-Authored-By: Stefan Ungureanu <stefan.ungureanu@tecnativa.com>
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-analytic_partner-BAD-TUG branch from 864813d to a964622 Compare August 9, 2023 07:01
pedrobaeza
pedrobaeza approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-573-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 9, 2023
@OCA-git-bot
Merge PR #573 into 15.0
e0ec8bc 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-573-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-573-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 133d9cf into OCA:15.0 Aug 9, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ed8eb37. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-analytic_partner-BAD-TUG branch August 9, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.