-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor image handling and add support for saving images as base64 s… #9
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for travel-tiger-x-daphne pending review.Visit the deploys page to approve it
|
@NotWoods let me know if you have any preference as to where to place the new function, I am currently struggling with the typing a little bit... |
Thank you for the PR! Reviews are going to be a bit slow right now as I'm on bereavement leave but I wanted to give some early feedback. I like the idea of being able to store the images, but I'm interested in using Astro's image APIs rather than just converting to base64. Base64 is pretty inefficient and will hurt the end-user experience as it will pages take much longer to download. Astro MDX uses a rehype parser to convert |
cool idea, like using the getImage function and store the optimized image? |
Yeah, I'm thinking of the |
As mentioned in the #8, to really use notion as a CMS, one needs to save the encoded images to the data-store.json to get all the benefits of a statically generated website.