Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove deprecated behavior #1220

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 27, 2024

Removes the following behavior, which has been deprecated for about a year:

  • Providing the id as the dataframe index, it has to be a column. Also the outputs from the methods will now always have the id as a column.
  • Providing sort_df to fit and cross_validation, we always check if it's sorted.

Also updates the documentation to remove usages of this behavior, docs that use datasetsforecast.losses and uses utilsforecast.plotting.plot_series instead of StatsForecast.plot

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review November 27, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant