Skip to content

Commit

Permalink
update comparison tutorial
Browse files Browse the repository at this point in the history
  • Loading branch information
jmoralez committed Nov 27, 2024
1 parent 350bd1f commit 55080fb
Show file tree
Hide file tree
Showing 4 changed files with 712 additions and 4,698 deletions.
4 changes: 2 additions & 2 deletions nbs/common.base_auto.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@
" test_size=test_size,\n",
" distributed_config=distributed_config,\n",
" )\n",
" trial.set_user_attr('config', user_cfg)\n",
" trial.set_user_attr('ALL_PARAMS', user_cfg)\n",
" metrics = model.metrics\n",
" trial.set_user_attr('METRICS', {\n",
" \"loss\": metrics[\"ptl/val_loss\"],\n",
Expand Down Expand Up @@ -445,7 +445,7 @@
" config=self.config,\n",
" distributed_config=distributed_config,\n",
" )\n",
" best_config = results.best_trial.user_attrs['config']\n",
" best_config = results.best_trial.user_attrs['ALL_PARAMS']\n",
" self.model = self._fit_model(\n",
" cls_model=self.cls_model,\n",
" config=best_config,\n",
Expand Down
2 changes: 1 addition & 1 deletion nbs/docs/capabilities/04_hyperparameter_tuning.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@
],
"source": [
"results = nf.models[0].results.trials_dataframe()\n",
"results.drop(columns='user_attrs_config')"
"results.drop(columns='user_attrs_ALL_PARAMS')"
]
},
{
Expand Down
Loading

0 comments on commit 55080fb

Please sign in to comment.