Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtreemfs: unpin Boost #359747

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Nov 28, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from tobim November 28, 2024 07:05
@tobim
Copy link
Contributor

tobim commented Nov 28, 2024

We should probably remove it xtreemfs/xtreemfs#500 instead.

@emilazy
Copy link
Member Author

emilazy commented Nov 28, 2024

It seems like it still gets a trickle of maintenance commits. OTOH, we’re pinning a commit even older than its 8½ year old stable version… so yeah, I wouldn’t object to dropping it. cc @7c6f434c @matejc – if we want to keep this we should probably at least bump to the current commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants