kikoplay: init at 1.0.3 #354929
Open
kikoplay: init at 1.0.3 #354929
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build kikoplay |
FliegendeWurst
suggested changes
Nov 22, 2024
| cmake, | ||
| qt5, | ||
| }: | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
This could be a real package in pkgs/by-name, I think.
There was a problem hiding this comment.
The qhttpengine package hasn't had an update over the last 6 years. It should not be used in any other package than KikoPlay.
ofborg
bot
added
8.has: package (new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KikoPlay is a video player that supports loading and displaying Danmu (bullet comments) for local media files.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.