Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: nixos.org/manual/nix -> nix.dev/manual/nix #335486

Conversation

tomodachi94
Copy link
Member

@tomodachi94 tomodachi94 commented Aug 17, 2024

Description of changes

The move happened here: NixOS/nix.dev#764

This is necessary because some redirects broke during the move.

Command used to get this result:

grep -rlF 'https://nixos.org/manual/nix/' ./ | xargs -I@ sed -i -e 's/https:\/\/nixos.org\/manual\/nix\/stable/https:\/\/nix.dev\/manual\/nix\/latest/g' @

For reviewers, here is a good way to ensure the updated links function:

nix-shell -p lychee --run "lychee doc/ --exclude '.*' --include 'https://nix.dev'"

If I did this wrong, please forgive me. This is my first treewide change.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The move happened here: NixOS/nix.dev#764

This is necessary because some redirects broke during the move.

Command used to get this result:
```
grep -rlF 'https://nixos.org/manual/nix/' ./ | xargs -I@ sed -i -e 's/https:\/\/nixos.org\/manual\/nix\/stable/https:\/\/nix.dev\/manual\/nix\/latest/g' @
```

For reviewers, here is a good way to ensure the updated links function:
```
nix-shell -p lychee --run "lychee doc/ --exclude '.*' --include 'https://nix.dev'"
```
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: policy discussion 6.topic: ruby 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library labels Aug 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 18, 2024
@tomodachi94
Copy link
Member Author

I'm wondering if this should wait until after NixOS/nix.dev#869 is completed?

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@tomodachi94
Copy link
Member Author

Closing, as I don't think this change is particularly necessary.

@tomodachi94 tomodachi94 closed this Nov 9, 2024
@tomodachi94 tomodachi94 deleted the enhance/treewide/update-unify-nix-manual-links branch November 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: haskell 6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion 6.topic: python 6.topic: ruby 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants