staging-next 2024-04-22

[vcunat]

According to the 24.05 schedule, this is the last staging-next iteration that might contain breaking changes to release critical packages.

Helpful links

• workflow docs: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging
• important jobs:
  https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
  https://hydra.nixos.org/job/nixos/staging-next-small/tested
• jobsets:
  https://hydra.nixos.org/jobset/nixpkgs/staging-next
  https://hydra.nixos.org/jobset/nixos/staging-next-small
• nix-review reports: https://malob.github.io/nix-review-tools-reports/
• previous staging-next: staging-next 2024-04-12 #303527

---

Mass breakages

nothing notable so far

[jtojnar]

Propagating just gobject-introspection.setupHook wouldn't fix python3Packages.pydbus build, so let me propagate it whole for now. (feel free to improve)

As mentioned above, you would need both the setup hook and glib. gobject-introspection itself is not needed.

To my knowledge you always needed the wrapper for applications for gobject stuff to work.

If you just needed GLib (or other bindings shipped with gobject-introspection), wrapper was not needed since ${gobject-introspection}/lib/girepository-1.0 is implicitly on typelib path. Now that GLib bindings were moved to glib package, ${glib}/lib/girepository-1.0 must be added to GI_TYPELIB_PATH by the wrapper (or gobject-introspection setup hook for build time).

[vcunat]

I now tried gobject-introspection.setupHook glib but it didn't suffice for python3Packages.pydbus.

[jtojnar]

Just tried it and it works for me:

diff --git a/pkgs/development/python-modules/pydbus/default.nix b/pkgs/development/python-modules/pydbus/default.nix
index fc8965fd3538..8e47b4489e17 100644
--- a/pkgs/development/python-modules/pydbus/default.nix
+++ b/pkgs/development/python-modules/pydbus/default.nix
@@ -3,6 +3,8 @@
 , fetchFromGitHub
 , setuptools
 , pygobject3
+, gobject-introspection
+, glib
 }:
 
 buildPythonPackage rec {
@@ -24,12 +26,17 @@ buildPythonPackage rec {
 
   nativeBuildInputs = [
     setuptools
+    gobject-introspection.setupHook
   ];
 
   propagatedBuildInputs = [
     pygobject3
   ];
 
+  buildInputs = [
+    glib
+  ];
+
   pythonImportsCheck = [
     "pydbus"
     "pydbus.generic"

[vcunat]

I was only modifying pygobject3. Maybe I didn't choose the right combination of native and propagated.

[jtojnar]

If I am reading the reference right, I believe, if pygobject3 goes to buildInputs ((0,1)), gobject-introspection.setupHook should go to depsBuildBuildPropagated ((-1,-1)) in pygobject3 to result in (-1,0) (nativeBuildInputs) in dependents, and glib should go to depsHostHostPropagated ((0,0)), if we want it in (0,1) (buildInputs).

[jtojnar]

I tried #308488 and it fixes pydbus but it only works with glib in depsBuildBuildPropagated, not in depsHostHostPropagated I would expect.

Got to run now.

[vcunat]

Well, it's not great, bringing a few hundred build regressions (closest view probably here so far), mostly because of python packages – but:

• I see nothing critical
• just waiting wouldn't help much, most likely
• ZHF will be soon, so hopefully the issues will attract more attention and get reduced.