Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] electron_26-bin: 26.3.0 -> 26.6.10, electron_26: always use electron_26-bin #303493

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

teutat3s
Copy link
Member

Description of changes

Update and fix build of electron_26, although it is EOL.

The build from source for electron_26 is broken since commit d90fd6c.

https://hydra.nixos.org/build/255783237/nixlog/1
The error is

jq: error (at <stdin>:1): Cannot index string with string "patch_dir"

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The build from source is broken since commit
d90fd6c

https://hydra.nixos.org/build/255783237/nixlog/1
The error is
jq: error (at <stdin>:1): Cannot index string with string "patch_dir"
@teutat3s teutat3s requested a review from yu-re-ka April 11, 2024 23:39
@teutat3s teutat3s added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 11, 2024
@yu-re-ka yu-re-ka merged commit a3ed575 into NixOS:release-23.11 Apr 12, 2024
25 of 26 checks passed
@teutat3s teutat3s deleted the electron_26-fixes branch April 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants