Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] prismlauncher: 8.0 -> 8.3 #301756

Merged
merged 8 commits into from
Apr 27, 2024
Merged

[23.11] prismlauncher: 8.0 -> 8.3 #301756

merged 8 commits into from
Apr 27, 2024

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Apr 5, 2024 •
edited
Loading

Description of changes

This backports all Prism Launcher commits

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex Scrumplex mentioned this pull request Apr 5, 2024
Closed
1 task
@Scrumplex Scrumplex added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software labels Apr 5, 2024
@ofborg ofborg bot requested review from Minion3665 and getchoo April 5, 2024 07:59
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 23, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1601

Scrumplex and others added 3 commits April 26, 2024 10:10
@Scrumplex
prismlauncher: add vulkan-loader
ca0d3fe 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@thecaralice @Scrumplex
prismlauncher: fix darwin
ed73d37 
Previously, `glfw-wayland-minecraft` would always be required and the
macOS application would be located at `<store entry>/PrismLauncher.app`,
while certain utilities (i.e. `home-manager`) expect it to be at
`<store entry>/Applications/PrismLauncher.app`
@getchoo @Scrumplex
prismlauncher: 8.2 -> 8.3
9dcfc53 
Diff: PrismLauncher/PrismLauncher@8.2...8.3

Changelog: https://github.com/PrismLauncher/PrismLauncher/releases/tag/8.3
@Scrumplex Scrumplex changed the title [23.11] prismlauncher: 8.0 -> 8.2 [23.11] prismlauncher: 8.0 -> 8.3 Apr 26, 2024
@ofborg ofborg bot requested a review from getchoo April 26, 2024 08:31
@Aleksanaa Aleksanaa merged commit 352f296 into NixOS:release-23.11 Apr 27, 2024
24 checks passed
@Scrumplex Scrumplex deleted the pkgs/prismlauncher/23.11-backport-1 branch September 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Minion3665 Minion3665 Awaiting requested review from Minion3665

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 11.by: upstream-developer This issue or PR was created by the developer of packaged software 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Scrumplex @nixos-discourse @getchoo @Aleksanaa @TomaSajt @wegank @thecaralice