Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.textual-universal-directorytree: add patch #288266

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 12, 2024

Description of changes

Fix build (https://hydra.nixos.org/build/248964207)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 0.kind: build failure A package fails to build label Feb 12, 2024
@fabaff
Copy link
Member Author

fabaff commented Feb 12, 2024

Support for Python 3.12 for universal-pathlib is coming: fsspec/universal_pathlib#152

@fabaff
Copy link
Member Author

fabaff commented Feb 12, 2024

Result of nixpkgs-review pr 288266 run on x86_64-linux 1

4 packages failed to build:
  • browsr
  • browsr.dist
  • python312Packages.textual-universal-directorytree
  • python312Packages.textual-universal-directorytree.dist
2 packages built:
  • python311Packages.textual-universal-directorytree
  • python311Packages.textual-universal-directorytree.dist

@ofborg ofborg bot requested a review from figsoda February 12, 2024 11:12
@fabaff fabaff merged commit 641d3ae into NixOS:master Feb 13, 2024
26 checks passed
@fabaff fabaff deleted the textual-universal-directorytree-fix branch February 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant