-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composefs: 1.0.2 -> 1.0.3 #284793
composefs: 1.0.2 -> 1.0.3 #284793
Conversation
Looks like systemd is not very happy with these tests on aarch64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple change + tests LGTM.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3508 |
What do we do about it? I don't want to mark the package broken. |
The tests were added to verify updating this package doesn't break perlless activation and don't actually indicate problems with this package by itself, but it looks like that test never succeeded on aarch64 even before this update. I'd like to keep the tests imported so at least the |
686f3d7
to
d62e2ee
Compare
Created an issue for the build failure at #291398, and disabled the linked test for this package. |
@ofborg test activation-etc-overlay-immutable activation-etc-overlay-mutable |
d62e2ee
to
542b6bf
Compare
Description of changes
Changes since 1.0.2:
Also inherit #270727
nixosTests
since it depends on composefs.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.