Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composefs: 1.0.2 -> 1.0.3 #284793

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

Kiskae
Copy link
Contributor

@Kiskae Kiskae commented Jan 29, 2024

Description of changes

Changes since 1.0.2:

  • Image format version 1 was added that allows storing overlay whiteouts in a composefs image.
  • libcomposefs added max_version option
  • mkcomposefs added --version and --max-version options
  • composefs can now be build without go-md2man
  • Minor bugfix handling file read errors

Also inherit #270727 nixosTests since it depends on composefs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 29, 2024
@Kiskae Kiskae requested a review from wegank January 29, 2024 16:51
@Kiskae
Copy link
Contributor Author

Kiskae commented Jan 29, 2024

machine # [ 8.933153] systemd[1]: Assertion 'close_nointr(fd) != -EBADF' failed at src/basic/fd-util.c:75, function safe_close(). Aborting.
machine # [ 8.934445] systemd[1]: Caught , from our own process.

Looks like systemd is not very happy with these tests on aarch64.

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple change + tests LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3508

@SuperSandro2000
Copy link
Member

Looks like systemd is not very happy with these tests on aarch64.

What do we do about it? I don't want to mark the package broken.

@Kiskae
Copy link
Contributor Author

Kiskae commented Feb 25, 2024

Looks like systemd is not very happy with these tests on aarch64.

What do we do about it? I don't want to mark the package broken.

The tests were added to verify updating this package doesn't break perlless activation and don't actually indicate problems with this package by itself, but it looks like that test never succeeded on aarch64 even before this update.

I'd like to keep the tests imported so at least the x86_64 implementation can be tested, but I'm not sure what to do about the aarch64 test for perlless activation.

@Kiskae
Copy link
Contributor Author

Kiskae commented Feb 25, 2024

Created an issue for the build failure at #291398, and disabled the linked test for this package.

@SuperSandro2000
Copy link
Member

@ofborg test activation-etc-overlay-immutable activation-etc-overlay-mutable

@SuperSandro2000 SuperSandro2000 merged commit 32a6d56 into NixOS:master Mar 1, 2024
23 checks passed
@Kiskae Kiskae deleted the composefs/1.0.3 branch March 1, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants