add _no_check targets

NilFoundation · Apr 16, 2024 · 18711a3 · 18711a3
1 parent 6a90049
commit 18711a3
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 3 deletions.
diff --git a/.github/workflows/build_linux.yml b/.github/workflows/build_linux.yml
@@ -163,7 +163,7 @@ jobs:
 
       - name: Build assignment tables(.tbl) of the C++ examples
         run: |
-          cmake --build build -t cpp_examples_generate_tbl
+          cmake --build build -t cpp_examples_generate_tbl_no_check
           ls -al ./build/examples/cpp
 
       - name: Run size estimation for C++ examples

diff --git a/.github/workflows/build_macos.yml b/.github/workflows/build_macos.yml
@@ -120,7 +120,7 @@ jobs:
 
       - name: Build assignment tables(.tbl) of the C++ examples
         run: |
-          cmake --build build -t cpp_examples_generate_tbl
+          cmake --build build -t cpp_examples_generate_tbl_no_check
           ls -al ./build/examples/cpp
 
       - name: Run size estimation for C++ examples

diff --git a/bin/assigner/src/main.cpp b/bin/assigner/src/main.cpp
@@ -703,7 +703,7 @@ int curve_dependent_main(std::string bytecode_file_name,
     BOOST_LOG_TRIVIAL(debug) << "overall_table_printing_duration: " << overall_table_printing_duration.count() << "ms";
 
     auto check_validity_start = std::chrono::high_resolution_clock::now();
-    if (check_validity && gen_mode.has_assignments() && gen_mode.has_circuit()) {
+    if (check_validity && gen_mode.has_assignments()) {
         if (assigner_instance.assignments.size() == 1 && (target_prover == 0 || target_prover == invalid_target_prover)) {
             ASSERT_MSG(nil::blueprint::is_satisfied(assigner_instance.circuits[0].get(), assigner_instance.assignments[0].get()),
                        "The circuit is not satisfied");

diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt
@@ -56,6 +56,20 @@ function(assign_ir)
         COMMAND_EXPAND_LISTS
         VERBATIM)
 
+    add_custom_target(${target}_generate_both_no_check
+        COMMAND $<TARGET_FILE:assigner>
+            -b ${binary_name}
+            -i ${INPUTS_DIR}/${input}
+            ${minus_p} ${private_input_string}
+            -c circuit_${target}.crct
+            -t assignment_${target}.tbl -e ${curve_type}
+            --generate-type circuit-assignment
+            ${max_num_provers_flag} ${max_num_provers_amount}
+            ${arithmetization_flag} ${arithmetization_amount}
+        DEPENDS ${target} ${INPUTS_DIR}/${input} $<TARGET_FILE:assigner>
+        COMMAND_EXPAND_LISTS
+        VERBATIM)
+
     add_custom_target(${target}_generate_tbl
         COMMAND $<TARGET_FILE:assigner>
             -b ${binary_name}
@@ -69,6 +83,19 @@ function(assign_ir)
         COMMAND_EXPAND_LISTS
         VERBATIM)
 
+    add_custom_target(${target}_generate_tbl_no_check
+        COMMAND $<TARGET_FILE:assigner>
+            -b ${binary_name}
+            -i ${INPUTS_DIR}/${input}
+            ${minus_p} ${private_input_string}
+            -t assignment_${target}.tbl -e ${curve_type}
+            --generate-type assignment
+            ${max_num_provers_flag} ${max_num_provers_amount}
+            ${arithmetization_flag} ${arithmetization_amount}
+        DEPENDS ${target} ${INPUTS_DIR}/${input} $<TARGET_FILE:assigner>
+        COMMAND_EXPAND_LISTS
+        VERBATIM)
+
     add_custom_target(${target}_estimate_size
         COMMAND $<TARGET_FILE:assigner>
             -b ${binary_name}

diff --git a/examples/cpp/CMakeLists.txt b/examples/cpp/CMakeLists.txt
@@ -1,7 +1,9 @@
 add_custom_target(compile_cpp_examples)
 add_custom_target(cpp_examples_generate_tbl)
+add_custom_target(cpp_examples_generate_tbl_no_check)
 add_custom_target(cpp_examples_generate_crct)
 add_custom_target(cpp_examples_generate_both)
+add_custom_target(cpp_examples_generate_both_no_check)
 add_custom_target(prove_cpp_examples)
 add_custom_target(cpp_examples_estimate_size)
 
@@ -68,8 +70,10 @@ function(add_example_without_proving example_target)
     assign_ir(${example_target} ${binary_name} ${ARG_INPUT} ${ARG_PRIVATE_INPUT} ${ARG_CURVE_TYPE} ${ARG_ARITHMETIZARION} ${ARG_MAX_NUM_PROVERS})
 
     add_dependencies(cpp_examples_generate_tbl ${example_target}_generate_tbl)
+    add_dependencies(cpp_examples_generate_tbl_no_check ${example_target}_generate_tbl_no_check)
     add_dependencies(cpp_examples_generate_crct ${example_target}_generate_crct)
     add_dependencies(cpp_examples_generate_both ${example_target}_generate_both)
+    add_dependencies(cpp_examples_generate_both_no_check ${example_target}_generate_both_no_check)
     add_dependencies(cpp_examples_estimate_size ${example_target}_estimate_size)
 endfunction()