Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Year Entry Option #18

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Final Year Entry Option #18

merged 3 commits into from
Apr 15, 2023

Conversation

wgw0
Copy link
Collaborator

@wgw0 wgw0 commented Apr 15, 2023

Final Year Entry Student Option

This allows for the user to state that they entered at Final Year and so it calculates only using rule B relevant to Final Year Entry students.

This was referenced in this issue and this issue.

This is done by changing the isAnyMarkUnder40 check to only check if the marks in Final Year modules are below 40 when the checkbox is ticked.

I admit this may not be the best place for the checkbox on the page but that's easily changeable.
Also possible change:

The user needs to update their marks after selecting the checkbox because the check is inside a function not a function on its own.

💻 Project Issue

@wgw0 wgw0 self-assigned this Apr 15, 2023
@wgw0 wgw0 merged commit 795559a into master Apr 15, 2023
@wgw0 wgw0 deleted the fyEntryOption branch April 15, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant