Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color by columns that are 1d vectors #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Saksham20
Copy link
Contributor

@Saksham20 Saksham20 commented Jan 5, 2022

while plotting traces of image_masks from the PlaneSegmentation table, legend groups should only be made for those table columns that are 1d vectors. Columns for image_mask/pixel_mask/Centroid etc are 2d or 3d vectors, for which color by would not make sense. Additionally, for such columns there would be as many groups as no of rows.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #197 (bc6c909) into master (b2fee99) will decrease coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   67.72%   66.64%   -1.09%     
==========================================
  Files          32       32              
  Lines        2947     2947              
==========================================
- Hits         1996     1964      -32     
- Misses        951      983      +32     
Flag Coverage Δ
unittests 66.64% <ø> (-1.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/ophys.py 67.53% <ø> (-13.09%) ⬇️
nwbwidgets/base.py 68.42% <0.00%> (-3.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fee99...bc6c909. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants