-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonlinear regression simulations for existing split criteria #29
base: master
Are you sure you want to change the base?
Conversation
Split Criteria Comparison Experiment and ResultsFor each simulation type (Logarithmic, Sine, Square, Multiplicative, Independence)
|
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
examples/ensemble/plot_random_forest_regression_criteria_comparison.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great! I made some minor comments asking for stylistic changes to the comments.
This looks great. I think you wanted to make a PR to real sklearn right? My only concern is that the current NDD master has bunch of changes from other people that would be merged in as well. For this, I think the best course of action is to make a new branch, fetch the latest sklearn, add in these two examples along with the data generation code. Then make the PR from that branch. |
These changes have been made in both the real sklearn version and the NDD version
Reference Issues/PRs
Fixes Issue 16370 in scikit-learn. Also see Issue 2 in tealeaf.
What does this implement/fix? Explain your changes.
This PR adds simulations and plots that show how split criteria compare on several nonlinear regression simulations including sinusoidal, logarithmic, multiplicative, and independence. There is not much information on scikit-learn's documentation about how to go about choosing which to use (mse, mae, or friedman mse) for the
criterion
parameter. This example demonstrates how to go about finding differences and shows that it may not always matter which criterion is chosen.Any other comments?
This PR in
sklearn
will include these files:The other files that were changed for Vivek's PR will not be changed in sklearn.