Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete button to select compiled contracts #269

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

ashleendaly
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-remix-plugin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:49pm

Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From UI perspective looks good, but I can't delete the first element of the list (it's not even shows border on-hover for delete button), for other elements of the list works fine

…selectedContracts, as this was causing react hook errors whenever selectedContracts was changed from within the compiled contracts component.
…a selected contract.

- if there are no compiled contracts, i.e. if someone deletes all contracts, then do not return the select component.
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varex83 varex83 merged commit d5a08a2 into develop Oct 8, 2024
7 checks passed
@varex83 varex83 deleted the 268-add-ability-to-clean-old-contract-artifacts branch October 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants