Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #2278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnkushinDaniil
Copy link
Contributor

This pull request includes several updates to the Makefile to enhance its functionality and clarity. The most significant changes involve adding new phony targets, updating descriptions for existing targets, and refactoring node commands to use a common template.

Enhancements to functionality:

  • Added new phony targets to the .PHONY list, including rustdeps, juno, juno-cached, check-rust, generate, clean-testcache, test, test-cached, test-race, benchmarks, test-cover, install-deps, lint, tidy, format, clean, help, feedernode, node1, node2, node3, and pathfinder.

Improvements to descriptions:

  • Updated descriptions for existing targets such as juno, juno-cached, generate, clean-testcache, test, test-cached, test-race, benchmarks, test-cover, install-deps, lint, tidy, format, clean, and help to provide clearer guidance on their purpose. [1] [2] [3]

Refactoring for node commands:

  • Introduced a common template run_node for running nodes, which reduces redundancy and simplifies the node1, node2, node3, and pathfinder targets.

These changes collectively improve the usability and maintainability of the Makefile.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (7286fe7) to head (d81a3c9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
+ Coverage   75.16%   75.27%   +0.10%     
==========================================
  Files         107      107              
  Lines       11392    11392              
==========================================
+ Hits         8563     8575      +12     
+ Misses       2175     2168       -7     
+ Partials      654      649       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant