[ADD] notification standards #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+26
to
+29
| "item": { | ||
| "type": "social", | ||
| "path": "alice.near/post/main", | ||
| "blockHeight": 88260018, |
There was a problem hiding this comment.
Item shouldn't include the message. Item is more like a pointer. It provides enough information to identify the given item. E.g. for a post it indicates the following:
- type = "social" - means it belongs to social DB
- path = "alice.near/post/main" - absolute path the item, in this case for
alice.near - blockHeight = 88260018 - the block height when the information at the path above is written, if omitted it means the same as the notification (for example when you post smth, you don't have a block height until it's saved).
| "type": "social", | ||
| "path": "alice.near/post/main", | ||
| "blockHeight": 88260018, | ||
| "message": "" |
There was a problem hiding this comment.
Message can be included as part of the value, but not item
Comment on lines
+49
to
+57
| "value": { | ||
| "type": "alert", | ||
| "item": { | ||
| "type": "social", | ||
| "path": "https://near.gaming", | ||
| "blockHeight": 88260018, | ||
| "message": "It's your turn" | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't have a schema for items yet, but we should add it. Example for url below:
Suggested change
| "value": { | |
| "type": "alert", | |
| "item": { | |
| "type": "social", | |
| "path": "https://near.gaming", | |
| "blockHeight": 88260018, | |
| "message": "It's your turn" | |
| } | |
| } | |
| "value": { | |
| "type": "alert", | |
| "item": { | |
| "type": "url", | |
| "path": "https://near.gaming", | |
| }, | |
| "message": "It's your turn" | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.