Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Natron and NatronRenderer exit code. #993

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Change exit code to 0 when -v/--version or -h/--help are specified. This just makes its behavior more consistent with other applications.

Have you tested your changes (if applicable)? If so, how?

Yes. Installer still builds and passes tests. I also manually verified exit codes with command-lines like "Natron -v; echo $?"

Change exit code to 0 when -v/--version or -h/--help are specified.
@acolwell acolwell requested a review from devernay August 1, 2024 00:00
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolwell acolwell merged commit f63b74d into NatronGitHub:RB-2.6 Aug 1, 2024
3 checks passed
@acolwell acolwell deleted the fix_natron_exitcode branch August 1, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants